LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] 68360serial, remove broken optimisation
@ 2007-07-03 14:31 Alan Cox
  0 siblings, 0 replies; only message in thread
From: Alan Cox @ 2007-07-03 14:31 UTC (permalink / raw)
  To: akpm, linux-serial, linux-kernel

Remove the broken 'no termios change' optimisation for this driver.

Signed-off-by: Alan Cox <alan@redhat.com>

diff -u --new-file --exclude-from /usr/src/exclude --recursive linux.vanilla-2.6.22-rc6-mm1/drivers/serial/68360serial.c linux-2.6.22-rc6-mm1/drivers/serial/68360serial.c
--- linux.vanilla-2.6.22-rc6-mm1/drivers/serial/68360serial.c	2007-07-02 20:47:31.000000000 +0100
+++ linux-2.6.22-rc6-mm1/drivers/serial/68360serial.c	2007-07-02 21:11:07.000000000 +0100
@@ -934,8 +934,6 @@
 	/*
 	 * Set up parity check flag
 	 */
-#define RELEVANT_IFLAG(iflag) (iflag & (IGNBRK|BRKINT|IGNPAR|PARMRK|INPCK))
-
 	info->read_status_mask = (BD_SC_EMPTY | BD_SC_OV);
 	if (I_INPCK(info->tty))
 		info->read_status_mask |= BD_SC_FR | BD_SC_PR;
@@ -1527,11 +1525,6 @@
 {
 	ser_info_t *info = (ser_info_t *)tty->driver_data;
 
-	if (   (tty->termios->c_cflag == old_termios->c_cflag)
-	    && (   RELEVANT_IFLAG(tty->termios->c_iflag) 
-		== RELEVANT_IFLAG(old_termios->c_iflag)))
-	  return;
-
 	change_speed(info);
 
 #ifdef modem_control

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2007-07-03 14:25 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-07-03 14:31 [PATCH] 68360serial, remove broken optimisation Alan Cox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).