LKML Archive on
help / color / mirror / Atom feed
From: Alan Cox <>
To: Robert Hancock <>
Subject: Re: [PATCH] libata_acpi: A different strategy for using ACPI information
Date: Wed, 4 Jul 2007 10:49:54 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

> Looks fairly reasonable to me. However, I suspect any use of _GTM is 
> somewhat dangerous (at least after the resume) unless we use the _STM 
> and _GTF methods in the proper sequence when resuming. (Is that in the 
> -mm tree now?)

Yes - and we only use it in these drivers to check for cable evidence not
for anything more serious.

> speed we give it is valid, since there is no sane way for the function 
> to indicate failure. (Thus the problem with the "cram in all possible 
> values to see what it supports" strategy for determining mode limits..)

The spec I have says it'll hand back the mode it actually uses which is
effectively a solution for 'failure'

  reply	other threads:[~2007-07-04  9:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <>
2007-07-03 23:53 ` [PATCH] libata_acpi: A different strategy for using ACPI information Robert Hancock
2007-07-04  9:49   ` Alan Cox [this message]
2007-07-03 14:54 Alan Cox
2007-07-04  3:49 ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).