LKML Archive on
help / color / mirror / Atom feed
From: Jesper Juhl <>
To: Linux Kernel Mailing List <>
Cc: Manuel Jander <>,
	Jesper Juhl <>,
Subject: [PATCH] au88x0: mem leak fix in snd_vortex_create()
Date: Sat, 4 Aug 2007 02:09:25 +0200	[thread overview]
Message-ID: <> (raw)


In sound/pci/au88x0/au88x0.c::snd_vortex_create() : 
The Coverity checker found that if we allocate storage for 'chip' 
but then leave via the  regions_out:  label, then we end up leaking 
the storage allocated for 'chip'.
I believe simply freeing 'chip' before the "return err;" line is 
all we need to fix this, but please double-check me :)

Signed-off-by: Jesper Juhl <>

diff --git a/sound/pci/au88x0/au88x0.c b/sound/pci/au88x0/au88x0.c
index 5ec1b6f..f70286a 100644
--- a/sound/pci/au88x0/au88x0.c
+++ b/sound/pci/au88x0/au88x0.c
@@ -232,6 +232,7 @@ snd_vortex_create(struct snd_card *card, struct pci_dev *pci, vortex_t ** rchip)
 	//FIXME: this not the right place to unregister the gameport
+	kfree(chip);
 	return err;

             reply	other threads:[~2007-08-04  0:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-04  0:09 Jesper Juhl [this message]
2007-08-04  9:47 ` Rene Herman
2007-08-06 12:06 ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \
    --subject='Re: [PATCH] au88x0: mem leak fix in snd_vortex_create()' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).