LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Cal Peake <cp@absolutedigital.net>,
	Chuck Ebbert <cebbert@redhat.com>,
	Gabriel C <nix.or.die@googlemail.com>,
	Frank Hale <frankhale@gmail.com>,
	Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Kernel ACPI Mailing List <linux-acpi@vger.kernel.org>,
	len.brown@intel.com, Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@elte.hu>,
	Andrew Morton <akpm@linux-foundation.org>,
	Andi Kleen <andi@firstfloor.org>
Subject: Re: ACPI on Averatec 2370
Date: Sat, 4 Aug 2007 11:30:35 +0200	[thread overview]
Message-ID: <20070804093035.GA25389@one.firstfloor.org> (raw)
In-Reply-To: <alpine.LFD.0.999.0708031447420.8184@woody.linux-foundation.org>

> > amd_apic_timer_broken: forcing return value of 1
> 
> since this makes it all work for you, it does appear that the AMD local 
> timer stops in C1 even when that isn't true, and as such is not useful.

Probably messed up SMM code. Might not apply to all AMD CPUs.

> Sad. It probably means that we have to disable the local timer for *all* 
> modern AMD CPU's.

I saw an APIC timer problem on a older AMD laptop too (long before RevF).
Back then I asked and it was apparently some SMM bug of that specific
BIOS.

What exact type of machine is it?
 

> 
> Thomas/Ingo - did something change in the local apic programming? Or why 
> did this work before? Was it just that we didn't use the local timer apic 

We used to always use the interrupt 0 too, which woke up the CPU and
then piggy backed the APIC interrupt too which works once the CPU
is woken.

Thomas changed that then when he redid the code for clock sources
because interrupt 0/PIT isn't good for frequent reprogramming. 

I did similar experiments some time ago but found it caused a lot of
problems and wasn't as brave as Thomas in working through them, so
i never pushed these patches.

-Andi

  reply	other threads:[~2007-08-04  9:30 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-29 18:05 Frank Hale
2007-07-29 18:13 ` Gabriel C
2007-07-29 18:45   ` Cal Peake
2007-07-29 18:58     ` Frank Hale
2007-07-29 19:58       ` Frank Hale
2007-07-30 15:20   ` Cal Peake
2007-08-02 17:50     ` Cal Peake
2007-08-02 19:09       ` Chuck Ebbert
2007-08-02 19:42         ` Cal Peake
2007-08-02 20:26           ` Chuck Ebbert
2007-08-02 20:30             ` Cal Peake
2007-08-02 20:51               ` Frank Hale
2007-08-02 21:07               ` Linus Torvalds
2007-08-02 21:53                 ` Cal Peake
2007-08-03 21:56                   ` Linus Torvalds
2007-08-04  9:30                     ` Andi Kleen [this message]
2007-08-04 13:50                       ` Frank Hale
2007-08-05 14:26                       ` Thomas Renninger
2007-08-07 22:15                     ` Cal Peake
2007-08-08  0:06                       ` Andi Kleen
2007-08-08  0:53                         ` [PATCH] drop unneeded variable in amd_apic_timer_broken Cal Peake
2007-08-08 14:36                           ` Andi Kleen
2007-08-08 16:00                             ` Cal Peake
2007-08-08 18:25                               ` Tim Gardner
2007-08-08 14:41                         ` ACPI on Averatec 2370 Joachim Deguara
2007-08-08 23:52                           ` Frank Hale
2007-08-09  9:45                             ` Joachim Deguara
2007-08-03 15:52                 ` Ben Collins
2007-08-03 18:19                   ` Chuck Ebbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070804093035.GA25389@one.firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=akpm@linux-foundation.org \
    --cc=cebbert@redhat.com \
    --cc=cp@absolutedigital.net \
    --cc=frankhale@gmail.com \
    --cc=len.brown@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=nix.or.die@googlemail.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: ACPI on Averatec 2370' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).