LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Chuck Ebbert <cebbert@redhat.com>,
	Muli Ben-Yehuda <muli@il.ibm.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	riku.seppala@kymp.net, Andy Whitcroft <apw@shadowen.org>
Subject: Re: Oops in 2.6.23-rc1-git9, arch/x86_64/pci/k8-bus.c::fill_mp_bus_to_cpumask()
Date: Sat, 4 Aug 2007 11:30:41 +0200	[thread overview]
Message-ID: <200708041130.42038.ak@suse.de> (raw)
In-Reply-To: <20070803155035.1fb11c9a.akpm@linux-foundation.org>

On Saturday 04 August 2007 00:50, Andrew Morton wrote:
> On Fri, 03 Aug 2007 18:10:03 -0400
>
> Chuck Ebbert <cebbert@redhat.com> wrote:
> > https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250859
> >
> > at line 74:
> >
> > muli@62829:
> > muli@62829: 					sd = bus->sysdata;
> > muli@62829: 					sd->node = node;   <=====
> >
> > bus->sysdata is NULL.
> >
> > Last changed by this hunk of
> > "x86-64: introduce struct pci_sysdata to facilitate sharing of
> > ->sysdata":

Hmm, will double check. Perhaps Muli's conversion was incomplete.

> > @@ -67,7 +69,9 @@ fill_mp_bus_to_cpumask(void)
> >  						continue;
> >  					if (!node_online(node))
> >  						node = 0;
> > -					bus->sysdata = (void *)node;
> > +
> > +					sd = bus->sysdata;
> > +					sd->node = node;
> >  				}
> >  			}
> >  		}
>
> Andy keeps trotting out a patch which will probably fix this,

What patch do you mean? I don't have anything sysdata related
left over.

-Andi

  parent reply	other threads:[~2007-08-04  9:32 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-03 22:10 Chuck Ebbert
2007-08-03 22:50 ` Andrew Morton
2007-08-04  6:17   ` Muli Ben-Yehuda
2007-08-04  9:30   ` Andi Kleen [this message]
2007-08-04 16:32     ` Andrew Morton
2007-08-04 17:45       ` Yinghai Lu
2007-08-04 18:15         ` Andrew Morton
2007-08-04 19:02           ` Yinghai Lu
2007-08-05  5:52             ` Andrew Morton
2007-08-05  6:02               ` Muli Ben-Yehuda
2007-08-05  6:07                 ` Yinghai Lu
2007-08-05  6:11                   ` Muli Ben-Yehuda
2007-08-05  6:24                     ` Yinghai Lu
2007-08-05  6:27                       ` Yinghai Lu
2007-08-05  6:04               ` Yinghai Lu
2007-08-04 23:40       ` Andi Kleen
2007-08-05  4:15         ` Muli Ben-Yehuda
2007-08-05  4:33           ` Yinghai Lu
2007-08-05  5:00             ` Muli Ben-Yehuda
2007-08-05  4:31         ` Yinghai Lu
2007-08-05  5:04         ` Muli Ben-Yehuda
2007-08-05  5:38           ` Yinghai Lu
2007-08-05  7:53             ` [PATCH/RFT] finish i386 and x86-64 sysdata conversion Muli Ben-Yehuda
2007-08-05  8:49               ` Yinghai Lu
2007-08-05 11:54                 ` Muli Ben-Yehuda
2007-08-05 16:39                   ` Yinghai Lu
2007-08-05 17:36                     ` Jeff Garzik
2007-08-05 20:41                       ` Yinghai Lu
2007-08-07 22:49               ` Andrew Morton
2007-08-07 22:56                 ` Muli Ben-Yehuda
2007-08-08  0:43                   ` Jeff Garzik
2007-08-08  1:09                     ` Yinghai Lu
2007-08-08  1:21                       ` Jeff Garzik
2007-08-08  1:28                         ` Yinghai Lu
2007-08-08  2:59                         ` Yinghai Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200708041130.42038.ak@suse.de \
    --to=ak@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=apw@shadowen.org \
    --cc=cebbert@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=muli@il.ibm.com \
    --cc=riku.seppala@kymp.net \
    --subject='Re: Oops in 2.6.23-rc1-git9, arch/x86_64/pci/k8-bus.c::fill_mp_bus_to_cpumask()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).