LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [2.6 patch] drivers/video/geode/lxfb_core.c: cleanups
@ 2007-08-04 13:02 Adrian Bunk
  2007-08-04 13:24 ` Eugene Teo
  0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2007-08-04 13:02 UTC (permalink / raw)
  To: Jordan Crouse, Antonino Daplas; +Cc: linux-kernel

This pacth contains the following cleanups:
- make the needlessly global geode_modedb[] static
- lxfb_setup(): remove an unused variable

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

 drivers/video/geode/lxfb_core.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

6ff33bdabb002b71b60258da40b3021b0d0a1ee2 
diff --git a/drivers/video/geode/lxfb_core.c b/drivers/video/geode/lxfb_core.c
index 5e30b40..2932863 100644
--- a/drivers/video/geode/lxfb_core.c
+++ b/drivers/video/geode/lxfb_core.c
@@ -34,7 +34,7 @@ static int fbsize;
  * we try to make it something sane - 640x480-60 is sane
  */
 
-const struct fb_videomode geode_modedb[] __initdata = {
+static const struct fb_videomode geode_modedb[] __initdata = {
 	/* 640x480-60 */
 	{ NULL, 60, 640, 480, 39682, 48, 8, 25, 2, 88, 2,
 	  FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT,
@@ -561,8 +561,6 @@ static struct pci_driver lxfb_driver = {
 #ifndef MODULE
 static int __init lxfb_setup(char *options)
 {
-	char *opt;
-
 	if (!options || !*options)
 		return 0;
 


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [2.6 patch] drivers/video/geode/lxfb_core.c: cleanups
  2007-08-04 13:02 [2.6 patch] drivers/video/geode/lxfb_core.c: cleanups Adrian Bunk
@ 2007-08-04 13:24 ` Eugene Teo
  0 siblings, 0 replies; 2+ messages in thread
From: Eugene Teo @ 2007-08-04 13:24 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: Jordan Crouse, Antonino Daplas, linux-kernel

<quote sender="Adrian Bunk">
> This pacth contains the following cleanups:
> - make the needlessly global geode_modedb[] static
> - lxfb_setup(): remove an unused variable

I have submitted a patch for the 2nd cleanup:
http://marc.info/?l=linux-mm-commits&m=118616305111463&w=2

Thanks,
Eugene

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-08-04 13:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-08-04 13:02 [2.6 patch] drivers/video/geode/lxfb_core.c: cleanups Adrian Bunk
2007-08-04 13:24 ` Eugene Teo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).