LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH][RESEND][Trivial] Documentation: sysrq, description of 'h' slightly inaccurate
@ 2007-08-04 18:31 Jesper Juhl
  2007-08-13 18:48 ` Randy Dunlap
  0 siblings, 1 reply; 2+ messages in thread
From: Jesper Juhl @ 2007-08-04 18:31 UTC (permalink / raw)
  To: Andrew Morton
  Cc: linux-kernel, vulpyne, trivial, crutcher+kernel, jesper.juhl

(Resending a patch from 21 May 2007 that never got any response)


Hello,

In Documentation/sysrq.txt, the description of 'h' says that any key not 
listed *above* will generate help. That's obviously not true since all the 
keys listed below 'h' will do what they are described to do, not display 
help. So change the text so that it says that any key not listed in the 
table will generate help, which is what really happens.


Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
---

 Documentation/sysrq.txt |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/sysrq.txt b/Documentation/sysrq.txt
index ba328f2..865b271 100644
--- a/Documentation/sysrq.txt
+++ b/Documentation/sysrq.txt
@@ -1,6 +1,6 @@
 Linux Magic System Request Key Hacks
 Documentation for sysrq.c
-Last update: 2007-MAR-14
+Last update: 2007-AUG-04
 
 *  What is the magic SysRq key?
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
@@ -78,7 +78,7 @@ On all -  write a character to /proc/sysrq-trigger.  e.g.:
 'g'	- Used by kgdb on ppc and sh platforms.
 
 'h'     - Will display help (actually any other key than those listed
-          above will display help. but 'h' is easy to remember :-)
+          here will display help. but 'h' is easy to remember :-)
 
 'i'     - Send a SIGKILL to all processes, except for init.
 


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH][RESEND][Trivial] Documentation: sysrq, description of 'h' slightly inaccurate
  2007-08-04 18:31 [PATCH][RESEND][Trivial] Documentation: sysrq, description of 'h' slightly inaccurate Jesper Juhl
@ 2007-08-13 18:48 ` Randy Dunlap
  0 siblings, 0 replies; 2+ messages in thread
From: Randy Dunlap @ 2007-08-13 18:48 UTC (permalink / raw)
  To: Jesper Juhl
  Cc: Andrew Morton, linux-kernel, vulpyne, trivial, crutcher+kernel

On Sat, 4 Aug 2007 20:31:27 +0200 Jesper Juhl wrote:

> (Resending a patch from 21 May 2007 that never got any response)
> 
> 
> Hello,
> 
> In Documentation/sysrq.txt, the description of 'h' says that any key not 
> listed *above* will generate help. That's obviously not true since all the 
> keys listed below 'h' will do what they are described to do, not display 
> help. So change the text so that it says that any key not listed in the 
> table will generate help, which is what really happens.
> 
> 
> Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>

Acked-by: Randy Dunlap <randy.dunlap@oracle.com>

Probably due to my alphabetization of the sysrq keys.

> ---
> 
>  Documentation/sysrq.txt |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/sysrq.txt b/Documentation/sysrq.txt
> index ba328f2..865b271 100644
> --- a/Documentation/sysrq.txt
> +++ b/Documentation/sysrq.txt
> @@ -1,6 +1,6 @@
>  Linux Magic System Request Key Hacks
>  Documentation for sysrq.c
> -Last update: 2007-MAR-14
> +Last update: 2007-AUG-04
>  
>  *  What is the magic SysRq key?
>  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> @@ -78,7 +78,7 @@ On all -  write a character to /proc/sysrq-trigger.  e.g.:
>  'g'	- Used by kgdb on ppc and sh platforms.
>  
>  'h'     - Will display help (actually any other key than those listed
> -          above will display help. but 'h' is easy to remember :-)
> +          here will display help. but 'h' is easy to remember :-)
>  
>  'i'     - Send a SIGKILL to all processes, except for init.
>  
> 
> -

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-08-13 18:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-08-04 18:31 [PATCH][RESEND][Trivial] Documentation: sysrq, description of 'h' slightly inaccurate Jesper Juhl
2007-08-13 18:48 ` Randy Dunlap

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).