LKML Archive on
help / color / mirror / Atom feed
* [PATCH][RESEND][pnp] Avoid a small unlikely memory leak in proc_read_escd()
@ 2007-08-04 18:32 Jesper Juhl
  0 siblings, 0 replies; only message in thread
From: Jesper Juhl @ 2007-08-04 18:32 UTC (permalink / raw)
  To: Andrew Morton
  Cc: Linux Kernel Mailing List, Thomas Hood, David Hinds, Jesper Juhl

(Resending patch originally submitted on 20/7-2007 23:41)


There's a small and unlikely memory leak in 
drivers/pnp/pnpbios/proc.c::proc_read_escd(). It's inside a sanity 
check, so it probably won't trigger often (if at all), however it 
*is* a potential leak and it's easy to avoid, so let's just fix it :)

While I was in there I also broke a oneline 'if' statement into two 
lines - seemed too trivial a changee to warrent a seperate patch.

Signed-off-by: Jesper Juhl <>

 drivers/pnp/pnpbios/proc.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/drivers/pnp/pnpbios/proc.c b/drivers/pnp/pnpbios/proc.c
index 8027073..f77b8c4 100644
--- a/drivers/pnp/pnpbios/proc.c
+++ b/drivers/pnp/pnpbios/proc.c
@@ -88,7 +88,8 @@ static int proc_read_escd(char *buf, char **start, off_t pos,
 	tmpbuf = kzalloc(escd.escd_size, GFP_KERNEL);
-	if (!tmpbuf) return -ENOMEM;
+	if (!tmpbuf)
+		return -ENOMEM;
 	if (pnp_bios_read_escd(tmpbuf, escd.nv_storage_base)) {
@@ -100,6 +101,7 @@ static int proc_read_escd(char *buf, char **start, off_t pos,
 	/* sanity check */
 	if (escd_size > MAX_SANE_ESCD_SIZE) {
 		printk(KERN_ERR "PnPBIOS: proc_read_escd: ESCD size reported by BIOS read_escd call is too great\n");
+		kfree(tmpbuf);
 		return -EFBIG;

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2007-08-04 18:37 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-08-04 18:32 [PATCH][RESEND][pnp] Avoid a small unlikely memory leak in proc_read_escd() Jesper Juhl

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).