LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: mel@skynet.ie (Mel Gorman)
To: Andi Kleen <ak@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Lee.Schermerhorn@hp.com, clameter@sgi.com,
	kamezawa.hiroyu@jp.fujitsu.com, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Apply memory policies to top two highest zones when highest zone is ZONE_MOVABLE
Date: Mon, 6 Aug 2007 22:55:41 +0100	[thread overview]
Message-ID: <20070806215541.GC6142@skynet.ie> (raw)
In-Reply-To: <200708062231.49247.ak@suse.de>

On (06/08/07 22:31), Andi Kleen didst pronounce:
> 
> > If correct, I would suggest merging the horrible hack for .23 then taking
> > it out when we merge "grouping pages by mobility".  But what if we don't do
> > that merge?
> 
> Or disable ZONE_MOVABLE until it is usable?

It's usable now. The issue with policies only occurs if the user specifies
kernelcore= or movablecore= on the command-line. Your language suggests
that you believe policies are not applied when ZONE_MOVABLE is configured
at build-time.

> I don't think we have the
> infrastructure to really use it anyways, so it shouldn't make too much difference
> in terms of features. And it's not that there is some sort of deadline
> around for it. 
> 
> Or mark it CONFIG_EXPERIMENTAL with a warning that it'll break NUMA. But disabling 
> is probably better.
> 

Saying it breaks NUMA is a excessively strong language. It doesn't break
policies in that they still get applied to the highest zone. If kernelcore=
or movablecore= is not specified, the behaviour doesn't change.

> Then for .24 or .25 a better solution can be developed.
> 

The better solution in my mind is to always filter the zonelist instead
of applying them only for MPOL_BIND zonelists as the hack does.

> I would prefer that instead of merging bandaid horrible hacks -- they have
> a tendency to stay around.

-- 
Mel Gorman
Part-time Phd Student                          Linux Technology Center
University of Limerick                         IBM Dublin Software Lab

  reply	other threads:[~2007-08-06 21:55 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-02 17:21 Mel Gorman
2007-08-02 19:41 ` Lee Schermerhorn
2007-08-02 20:45 ` Christoph Lameter
2007-08-06 19:44   ` Andrew Morton
2007-08-06 20:13     ` Christoph Lameter
2007-08-06 21:56   ` Paul Jackson
2007-08-03 22:02 ` Andi Kleen
2007-08-04  0:23   ` Mel Gorman
2007-08-04  8:51     ` Andi Kleen
2007-08-04 16:39       ` Mel Gorman
2007-08-06 19:15   ` Andrew Morton
2007-08-06 19:18     ` Christoph Lameter
2007-08-06 20:31     ` Andi Kleen
2007-08-06 21:55       ` Mel Gorman [this message]
2007-08-07  5:12         ` Andrew Morton
2007-08-07 16:55           ` Mel Gorman
2007-08-07 18:14             ` Andrew Morton
2007-08-07 20:37               ` Christoph Lameter
2007-08-08 16:49               ` Mel Gorman
2007-08-08 17:03                 ` Christoph Lameter
2007-08-06 21:48     ` Mel Gorman
2007-08-06 22:31       ` Christoph Lameter
2007-08-06 22:57         ` Mel Gorman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070806215541.GC6142@skynet.ie \
    --to=mel@skynet.ie \
    --cc=Lee.Schermerhorn@hp.com \
    --cc=ak@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=clameter@sgi.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --subject='Re: [PATCH] Apply memory policies to top two highest zones when highest zone is ZONE_MOVABLE' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).