LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Nicolas George <nicolas.george@normalesup.org>
To: linux-kernel@vger.kernel.org, uml-devel@lists.sourceforge.net
Subject: UML/man: BLKGETSIZE takes a long, not an int
Date: Mon, 13 Aug 2007 14:42:47 +0200	[thread overview]
Message-ID: <20070813124247.GA7414@she-seel.salle-s.org> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 559 bytes --]

Hi.

I found a type mismatch in UML that makes host block devices unusable as ubd
devices on x86_64 and other 64 bits systems (segfault of the mm subsystem):

In block/ioctl.c, the following lines show that the BLKGETSIZE ioctl expects
a pointer to a long:

	case BLKGETSIZE:
		if ((bdev->bd_inode->i_size >> 9) > ~0UL)
			return -EFBIG;
		return put_ulong(arg, bdev->bd_inode->i_size >> 9);

In arch/um/os-Linux/file.c, os_file_size calls it with an int.

The ioctl_list man page should be fixed as well.

Regards,

-- 
  Nicolas George

[-- Attachment #1.2: linux-umlblkgetsize-20070813.diff --]
[-- Type: text/x-diff, Size: 397 bytes --]

diff --git a/arch/um/os-Linux/file.c b/arch/um/os-Linux/file.c
index 6f92f73..c3ecc2a 100644
--- a/arch/um/os-Linux/file.c
+++ b/arch/um/os-Linux/file.c
@@ -320,7 +320,8 @@ int os_file_size(char *file, unsigned long long *size_out)
 	}
 
 	if(S_ISBLK(buf.ust_mode)){
-		int fd, blocks;
+		int fd;
+		long blocks;
 
 		fd = os_open_file(file, of_read(OPENFLAGS()), 0);
 		if(fd < 0){

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

             reply	other threads:[~2007-08-13 15:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-13 12:42 Nicolas George [this message]
2007-08-15 17:12 ` Jeff Dike
2007-08-15 21:38   ` [PATCH] UML: " Nicolas George
2007-08-16 14:48     ` Jeff Dike
2007-08-14  9:29 Nicolas George
2007-08-27 13:25 ` UML/man: BLKGETSIZE takes a long, not an int Michael Kerrisk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070813124247.GA7414@she-seel.salle-s.org \
    --to=nicolas.george@normalesup.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=uml-devel@lists.sourceforge.net \
    --subject='Re: UML/man: BLKGETSIZE takes a long, not an int' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).