LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Neil Horman <nhorman@tuxdriver.com>
To: John Blackwood <john.blackwood@ccur.com>
Cc: linux-rt-users@vger.kernel.org, linux-kernel@vger.kernel.org,
	Sven-Thorsten Dietrich <sdietrich@novell.com>,
	Gregory Haskins <ghaskins@novell.com>,
	Tom Horsley <tom.horsley@ccur.com>
Subject: Re: [PATCH] select: fix sys_select to not leak ERESTARTNOHAND to userspace
Date: Fri, 17 Aug 2007 16:55:55 -0400	[thread overview]
Message-ID: <20070817205555.GA15379@hmsreliant.think-freely.org> (raw)
In-Reply-To: <46C5C1A0.7060708@ccur.com>

On Fri, Aug 17, 2007 at 11:41:20AM -0400, John Blackwood wrote:
> Hi Neil,
> 
> We've been having problems with this select patch change.
> 
> Specifically -- previously, when a ptrace attach was done to a task
> blocked in a select() call and that task had a timeout value,
> the task would restart the select() call with an updated timeout value.
> 
> With this patch in place, the task now instead returns EINTR.
> 
> A test that shows this issue is provided below.
> 
> We also confirmed that attaching to a program sitting
> in select() with gdb makes the select get an EINTR, so this
> behavior also shows up in gdb.
> 
> Thank you for your considerations in this matter.
> 
I'm on vacation at the moment, but will look at this more closely when I get
back on tuesday
Regards
Neil

> ------------------- -------------------
> #include <stdio.h>
> #include <sys/time.h>
> #include <sys/types.h>
> #include <unistd.h>
> #include <errno.h>
> #include <stdlib.h>
> #include <string.h>
> #include <ctype.h>
> #include <time.h>
> #include <signal.h>
> #include <sys/wait.h>
> #include <sys/ptrace.h>
> 
> int
> main(int argc, char ** argv) {
>    pid_t kid;
>    if ((kid = fork()) == 0) {
>       int ms_wait = 2000;
>       int rval;
>       struct timeval timeout;
> 
>       timeout.tv_sec = ms_wait / 1000;
>       timeout.tv_usec = (ms_wait % 1000) * 1000;
>       rval = select(0, NULL, NULL, NULL, &timeout);
>       if (rval == -1) {
>          int errcode = errno;
>          printf("Hey! Why did my select error off with errno %d (%s)?\n",
>                 errcode, strerror(errcode));
>          fflush(stdout);
>       } else {
>          printf("select call completed, return value: %d\n", rval);
>       }
>       exit(0);
>    } else if (kid == (pid_t)-1) {
>       perror("fork");
>    } else {
>       int ms_wait = 500;
>       int rval;
>       struct timeval timeout;
> 
>       /* Wait a bit to make sure kid has a chance to get into its
>        * select call
>        */
>       timeout.tv_sec = ms_wait / 1000;
>       timeout.tv_usec = (ms_wait % 1000) * 1000;
>       rval = select(0, NULL, NULL, NULL, &timeout);
> 
>       /* Now attach to the kid, then continue him.
>        */
>       if (ptrace(PTRACE_ATTACH, kid, (void *)0, (void *)0) != 0) {
>          perror("ptrace");
>       }
>       if (waitpid(kid, &rval, 0) != kid) {
>          perror("waitpid");
>       }
>       if (ptrace(PTRACE_CONT, kid, (void *)0, (void *)0) != 0) {
>          perror("ptrace");
>       }
>       if (waitpid(kid, &rval, 0) != kid) {
>          perror("waitpid");
>       }
>    }
>    return 0;
> }

-- 
/***************************************************
 *Neil Horman
 *Software Engineer
 *Red Hat, Inc.
 *nhorman@tuxdriver.com
 *gpg keyid: 1024D / 0x92A74FA1
 *http://pgp.mit.edu
 ***************************************************/

  reply	other threads:[~2007-08-17 20:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-17 15:41 John Blackwood
2007-08-17 20:55 ` Neil Horman [this message]
  -- strict thread matches above, loose matches on Subject: below --
2007-01-16 20:13 Neil Horman
2007-01-22 13:59 ` Paolo Ornati
2007-01-22 14:52   ` Neil Horman
2007-01-22 16:03     ` Linus Torvalds
2007-01-22 16:24       ` Neil Horman
2007-01-23  0:00         ` bert hubert
2007-01-24  5:59 ` David Miller
2007-01-24 13:21   ` Neil Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070817205555.GA15379@hmsreliant.think-freely.org \
    --to=nhorman@tuxdriver.com \
    --cc=ghaskins@novell.com \
    --cc=john.blackwood@ccur.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=sdietrich@novell.com \
    --cc=tom.horsley@ccur.com \
    --subject='Re: [PATCH] select: fix sys_select to not leak ERESTARTNOHAND to userspace' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).