LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Dmitry Torokhov <dtor@insightbb.com>
To: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: Pavel Machek <pavel@ucw.cz>, Len Brown <lenb@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-input@atrey.karlin.mff.cuni.cz,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fujitsu application panel driver (rev3)
Date: Sun, 16 Sep 2007 16:22:58 -0400	[thread overview]
Message-ID: <200709161623.00286.dtor@insightbb.com> (raw)
In-Reply-To: <20070916215516.2934abad@oldman.hemminger.net>

Hi Stephen,

On Sunday 16 September 2007 15:55, Stephen Hemminger wrote:
> On Fri, 14 Sep 2007 01:30:58 -0400
> Dmitry Torokhov <dtor@insightbb.com> wrote:
> 
> > Hi Stephen,
> > 
> > On Wednesday 12 September 2007 07:38, Stephen Hemminger wrote:
> > > This driver supports the application buttons on some Fujitsu Lifebook laptops.
> > > It is based on the earlier apanel driver done by Jochen Eisenger, but
> > > with many changes.  The original driver used ioctl's and a separate
> > > user space program;  see http://apanel.sourceforge.net/tech.php
> > > This version hooks into the input subsystem so that the normal
> > > Gnome/KDE shortcuts work without any userspace changes.
> > > 
> > > The Mail Led is handled via leds class device.
> > > 
> > 
> > Thank you very much for convering the led to led subsystem. I tried
> > implementing loadable keymap support in the driver, could you please
> > try the patch below and if it still works for you then I will apply
> > it to my tree.
> > 
> 
> Sorry, you are raising the bar for new drivers, higher than existing code.
> It is really bad (second system syndrome), if maintainers keep wanting
> new code to to more than existing drivers.
> 
> Please take driver AS IS. Go ahead and add loadable key map support,

I think I did that. I just asked you to run another test to make sure I did
not screw up. Please find the time to do that and the patch will be applied.
Unfortunately I do not own the hardware in question to do such test myself.

> but fix all the other drivers in the tree at the same time that use the existing
> interface.
> 

I will, time permitting. The support for doing loadable keymaps for drivers
with sparse scancodes (or their equivalent) was added not so long ago,
that's why there are a few drivers that don't implement loadable keymaps.
But still many others do.

-- 
Dmitry

  reply	other threads:[~2007-09-16 20:23 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-02 18:17 [PATCH] fujtisu application panel driver Stephen Hemminger
2007-07-02 19:16 ` Dmitry Torokhov
2007-09-03  8:58   ` Stephen Hemminger
2007-09-07 12:02     ` Pavel Machek
2007-09-12 11:38       ` [PATCH] Fujitsu application panel driver (rev3) Stephen Hemminger
2007-09-14  5:30         ` Dmitry Torokhov
2007-09-16 19:55           ` Stephen Hemminger
2007-09-16 20:22             ` Dmitry Torokhov [this message]
2007-10-23 19:55               ` [PATCH] Fujitsu application panel driver Stephen Hemminger
2007-10-24 23:03                 ` Andrew Morton
2007-10-25 20:19                   ` [PATCH] apanel: space savings Stephen Hemminger
2007-10-28  5:30                 ` [PATCH] Fujitsu application panel driver Dmitry Torokhov
2007-11-18 22:36                 ` Robert Gerlach
2007-11-19  4:43                   ` Stephen Hemminger
2007-11-19 12:50                     ` Robert Gerlach
2007-11-19 17:26                       ` Stephen Hemminger
2007-11-19 20:37                         ` Robert Gerlach
2007-11-19 23:19                       ` Stephen Hemminger
2007-12-19  9:04                         ` Robert Gerlach
2007-12-12 14:10                 ` Dmitry Torokhov
2007-12-12 22:21                   ` [PATCH] Fujitsu application panel led value Stephen Hemminger
2007-07-05  1:29 ` [PATCH] fujtisu application panel driver Jason Uhlenkott
2007-09-03  9:00   ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200709161623.00286.dtor@insightbb.com \
    --to=dtor@insightbb.com \
    --cc=akpm@linux-foundation.org \
    --cc=lenb@kernel.org \
    --cc=linux-input@atrey.karlin.mff.cuni.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=shemminger@linux-foundation.org \
    --subject='Re: [PATCH] Fujitsu application panel driver (rev3)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).