LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Matthew Wilcox <matthew@wil.cx>
To: Linas Vepstas <linas@austin.ibm.com>
Cc: linux-pcmcia@lists.infradead.org,
	Dominik Brodowski <linux@brodo.de>,
	linux-pci@atrey.karlin.mff.cuni.cz, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Simplify yenta code
Date: Mon, 1 Oct 2007 12:56:55 -0600	[thread overview]
Message-ID: <20071001185655.GM12049@parisc-linux.org> (raw)
In-Reply-To: <20071001184115.GB4338@austin.ibm.com>

On Mon, Oct 01, 2007 at 01:41:15PM -0500, Linas Vepstas wrote:
> -	if (type & IORESOURCE_IO) {
> -		if ((yenta_search_res(socket, res, BRIDGE_IO_MAX)) ||
> -		    (yenta_search_res(socket, res, BRIDGE_IO_ACC)) ||
> -		    (yenta_search_res(socket, res, BRIDGE_IO_MIN)))
> -			return 1;
> -	} else {
> -		if (type & IORESOURCE_PREFETCH) {
> -			if ((yenta_search_res(socket, res, BRIDGE_MEM_MAX)) ||
> -			    (yenta_search_res(socket, res, BRIDGE_MEM_ACC)) ||
> -			    (yenta_search_res(socket, res, BRIDGE_MEM_MIN)))
> -				return 1;
> -			/* Approximating prefetchable by non-prefetchable */
> -			res->flags = IORESOURCE_MEM;
> -		}
> +	if ((yenta_search_res(socket, res, BRIDGE_MEM_MAX)) ||
> +	    (yenta_search_res(socket, res, BRIDGE_MEM_ACC)) ||
> +	    (yenta_search_res(socket, res, BRIDGE_MEM_MIN)))

Are BRIDGE_IO_MAX and BRIDGE_MEM_MAX guaranteed to be the same?

-- 
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."

  reply	other threads:[~2007-10-01 18:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-01 18:41 Linas Vepstas
2007-10-01 18:56 ` Matthew Wilcox [this message]
2007-10-01 20:04   ` Linas Vepstas
2007-10-06  4:26 Komuro
2007-10-08 17:47 ` Linas Vepstas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071001185655.GM12049@parisc-linux.org \
    --to=matthew@wil.cx \
    --cc=linas@austin.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    --cc=linux-pcmcia@lists.infradead.org \
    --cc=linux@brodo.de \
    --subject='Re: [PATCH] Simplify yenta code' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).