LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* RE: [PATCH] Simplify yenta code
@ 2007-10-06  4:26 Komuro
  2007-10-08 17:47 ` Linas Vepstas
  2007-10-13 22:36 ` [NOT VERY SAFE] [TCP]: Set initial_ssthresh default to zero in Cubic and BIC Komuro
  0 siblings, 2 replies; 23+ messages in thread
From: Komuro @ 2007-10-06  4:26 UTC (permalink / raw)
  To: linux-kernel; +Cc: linas

Hello,

Unfortunately, your patch is wrong,
and does not results in the same run-time behaviour.

You broke the code of "if (type & IORESOURCE_IO)"
 

Best Regards
Komuro


>Simplify some of the resource detection logic in yenta_socket.
>This patch results in the same run-time behaviour as the 
>current code, but does so with fewer lines of code. This
>makes the logical flow of the code a bit easier to understand.
>
>Signed-off-by: Linas Vepstas <linas@austin.ibm.com>
>Cc: Dominik Brodowski <linux@brodo.de>
>
>----
> drivers/pcmcia/yenta_socket.c |   22 ++++++++--------------
> 1 file changed, 8 insertions(+), 14 deletions(-)
>
>Index: linux-2.6.23-rc8-mm1/drivers/pcmcia/yenta_socket.c
>===================================================================
>--- linux-2.6.23-rc8-mm1.orig/drivers/pcmcia/yenta_socket.c	2007-10-01 >12:17:02.000000000 -0500
>+++ linux-2.6.23-rc8-mm1/drivers/pcmcia/yenta_socket.c	2007-10-01 12:37:36.000000000 >-0500
>@@ -654,20 +654,14 @@ static int yenta_allocate_res(struct yen
> 				pci_name(socket->dev), nr);
> 	}
> 
>-	if (type & IORESOURCE_IO) {
>-		if ((yenta_search_res(socket, res, BRIDGE_IO_MAX)) ||
>-		    (yenta_search_res(socket, res, BRIDGE_IO_ACC)) ||
>-		    (yenta_search_res(socket, res, BRIDGE_IO_MIN)))
>-			return 1;
>-	} else {
>-		if (type & IORESOURCE_PREFETCH) {
>-			if ((yenta_search_res(socket, res, BRIDGE_MEM_MAX)) ||
>-			    (yenta_search_res(socket, res, BRIDGE_MEM_ACC)) ||
>-			    (yenta_search_res(socket, res, BRIDGE_MEM_MIN)))
>-				return 1;
>-			/* Approximating prefetchable by non-prefetchable */
>-			res->flags = IORESOURCE_MEM;
>-		}
>+	if ((yenta_search_res(socket, res, BRIDGE_MEM_MAX)) ||
>+	    (yenta_search_res(socket, res, BRIDGE_MEM_ACC)) ||
>+	    (yenta_search_res(socket, res, BRIDGE_MEM_MIN)))
>+		return 1;
>+
>+	if (type & IORESOURCE_PREFETCH) {
>+		/* Approximating prefetchable by non-prefetchable */
>+		res->flags = IORESOURCE_MEM;
> 		if ((yenta_search_res(socket, res, BRIDGE_MEM_MAX)) ||
> 		    (yenta_search_res(socket, res, BRIDGE_MEM_ACC)) ||
> 		    (yenta_search_res(socket, res, BRIDGE_MEM_MIN)))
>-

^ permalink raw reply	[flat|nested] 23+ messages in thread
* [PATCH] Simplify yenta code
@ 2007-10-01 18:41 Linas Vepstas
  2007-10-01 18:56 ` Matthew Wilcox
  0 siblings, 1 reply; 23+ messages in thread
From: Linas Vepstas @ 2007-10-01 18:41 UTC (permalink / raw)
  To: linux-pcmcia, Dominik Brodowski; +Cc: linux-pci, linux-kernel


Simplify some of the resource detection logic in yenta_socket.
This patch results in the same run-time behaviour as the 
current code, but does so with fewer lines of code. This
makes the logical flow of the code a bit easier to understand.

Signed-off-by: Linas Vepstas <linas@austin.ibm.com>
Cc: Dominik Brodowski <linux@brodo.de>

----
 drivers/pcmcia/yenta_socket.c |   22 ++++++++--------------
 1 file changed, 8 insertions(+), 14 deletions(-)

Index: linux-2.6.23-rc8-mm1/drivers/pcmcia/yenta_socket.c
===================================================================
--- linux-2.6.23-rc8-mm1.orig/drivers/pcmcia/yenta_socket.c	2007-10-01 12:17:02.000000000 -0500
+++ linux-2.6.23-rc8-mm1/drivers/pcmcia/yenta_socket.c	2007-10-01 12:37:36.000000000 -0500
@@ -654,20 +654,14 @@ static int yenta_allocate_res(struct yen
 				pci_name(socket->dev), nr);
 	}
 
-	if (type & IORESOURCE_IO) {
-		if ((yenta_search_res(socket, res, BRIDGE_IO_MAX)) ||
-		    (yenta_search_res(socket, res, BRIDGE_IO_ACC)) ||
-		    (yenta_search_res(socket, res, BRIDGE_IO_MIN)))
-			return 1;
-	} else {
-		if (type & IORESOURCE_PREFETCH) {
-			if ((yenta_search_res(socket, res, BRIDGE_MEM_MAX)) ||
-			    (yenta_search_res(socket, res, BRIDGE_MEM_ACC)) ||
-			    (yenta_search_res(socket, res, BRIDGE_MEM_MIN)))
-				return 1;
-			/* Approximating prefetchable by non-prefetchable */
-			res->flags = IORESOURCE_MEM;
-		}
+	if ((yenta_search_res(socket, res, BRIDGE_MEM_MAX)) ||
+	    (yenta_search_res(socket, res, BRIDGE_MEM_ACC)) ||
+	    (yenta_search_res(socket, res, BRIDGE_MEM_MIN)))
+		return 1;
+
+	if (type & IORESOURCE_PREFETCH) {
+		/* Approximating prefetchable by non-prefetchable */
+		res->flags = IORESOURCE_MEM;
 		if ((yenta_search_res(socket, res, BRIDGE_MEM_MAX)) ||
 		    (yenta_search_res(socket, res, BRIDGE_MEM_ACC)) ||
 		    (yenta_search_res(socket, res, BRIDGE_MEM_MIN)))

^ permalink raw reply	[flat|nested] 23+ messages in thread

end of thread, other threads:[~2008-03-08 11:56 UTC | newest]

Thread overview: 23+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-10-06  4:26 [PATCH] Simplify yenta code Komuro
2007-10-08 17:47 ` Linas Vepstas
2007-10-13 22:36 ` [NOT VERY SAFE] [TCP]: Set initial_ssthresh default to zero in Cubic and BIC Komuro
2007-10-13 22:52   ` David Miller
2007-10-13 22:54     ` David Miller
2007-10-14  1:02   ` Komuro
2007-10-14  2:38     ` David Miller
2007-10-14  4:30       ` Jeff Garzik
2007-10-14  4:28     ` Komuro
2007-10-14  4:32       ` David Miller
2007-10-14  4:53       ` Komuro
2007-10-14  5:23         ` David Miller
2007-10-15 12:59         ` Komuro
2007-10-15 15:55           ` Stephen Hemminger
2007-10-14 20:34     ` Stephen Hemminger
2008-03-02 12:07   ` [BUG kernel 2.6.25-rc3 IPV6] ping6 -I eth0 ff02::1 causes system hang Komuro
2008-03-04  7:40     ` Andrew Morton
2008-03-08  4:44     ` Komuro
2008-03-08  5:20       ` Komuro
2008-03-08 11:56       ` David Miller
  -- strict thread matches above, loose matches on Subject: below --
2007-10-01 18:41 [PATCH] Simplify yenta code Linas Vepstas
2007-10-01 18:56 ` Matthew Wilcox
2007-10-01 20:04   ` Linas Vepstas

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).