LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ralf Baechle <ralf@linux-mips.org>
To: Adrian Bunk <bunk@kernel.org>
Cc: "Maciej W. Rozycki" <macro@linux-mips.org>,
	Franck Bui-Huu <vagabon.xyz@gmail.com>,
	linux-arch@vger.kernel.org, linux-mips@linux-mips.org,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Discardable strings for init and exit sections
Date: Fri, 12 Oct 2007 18:52:10 +0100	[thread overview]
Message-ID: <20071012175209.GA1110@linux-mips.org> (raw)
In-Reply-To: <20071012171938.GB6476@stusta.de>

On Fri, Oct 12, 2007 at 07:19:38PM +0200, Adrian Bunk wrote:

> I have an objection against this approach:
> 
> Our __*init*/__*exit* annotations are already a constant source of bugs, 
> and adding more pifalls (e.g. forgotten removal of _i()/_e() when a 
> function is no longer __*init*/__*exit*) doesn't sound like a good plan.
> 
> Shouldn't it be possible to automatically determine where to put the 
> strings? I don't know enough gcc/ld voodoo for being able to tell 
> whether it is currently possible, and if yes how, but doing it 
> automatically sounds like the only solution that wouldn't result in an
> unmaintainable mess.

gcc tends to place data such as strings or jump tables generated from
switches not into a place were it would be easily discardable.  The
latter is the reason that on MIPS we can't discard __exit functions
at all - a switch table in .rodata might be referencing discarded code
in .exit.text which makes ld fail.  When I discussed this with some gcc
people a while ago nobody really had a good suggestion to solve this.

  Ralf

  reply	other threads:[~2007-10-12 17:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-12 16:50 Maciej W. Rozycki
2007-10-12 17:19 ` Adrian Bunk
2007-10-12 17:52   ` Ralf Baechle [this message]
2007-10-12 18:15     ` Adrian Bunk
2007-10-23 16:57       ` Maciej W. Rozycki
2007-10-23 17:12         ` Adrian Bunk
2007-10-23 17:25           ` Sam Ravnborg
2007-10-12 17:45 ` Sam Ravnborg
2007-10-23 17:23   ` Maciej W. Rozycki
2007-10-23 17:27     ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071012175209.GA1110@linux-mips.org \
    --to=ralf@linux-mips.org \
    --cc=akpm@linux-foundation.org \
    --cc=bunk@kernel.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=macro@linux-mips.org \
    --cc=vagabon.xyz@gmail.com \
    --subject='Re: [PATCH] Discardable strings for init and exit sections' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).