LKML Archive on
help / color / mirror / Atom feed
From: Alasdair G Kergon <>
To: Arnd Bergmann <>
Cc: Linus Torvalds <>,,,
	Milan Broz <>, Guido Guenther <>,
	Kevin Corry <>,
Subject: Re: [2.6.24 PATCH 02/25] dm io:ctl use constant struct size
Date: Mon, 15 Oct 2007 02:26:21 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Sat, Oct 13, 2007 at 12:16:29AM +0200, Arnd Bergmann wrote:
> This change seems rather bogus, you're changing the ABI just to work
> around a bug in the compat_ioctl layer. Why not just do the compat
> code the right way, like the patch below?

The underlying ABI is not changing, I hope - the trailing padding in the
struct should not affect the processing of the data by dm, and I see no
reason to continue maintaining the fiction that the 32-bit and 64-bit
ioctls are in some way incompatible with each other when they aren't

And yes, a follow-up patch can clean up our use of the compatibility
mechanism, going a little bit further than the patch you attached, I


  reply	other threads:[~2007-10-15  1:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-12 17:05 Alasdair G Kergon
2007-10-12 22:16 ` Arnd Bergmann
2007-10-15  1:26   ` Alasdair G Kergon [this message]
2007-10-15  7:34     ` Arnd Bergmann
2007-11-13 22:22       ` [stable] " Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [2.6.24 PATCH 02/25] dm io:ctl use constant struct size' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).