LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Komuro <komurojun-mbn@nifty.com>
To: shemminger@linux.foundation.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [NOT VERY SAFE]     [TCP]: Set initial_ssthresh default to zero in Cubic and BIC.
Date: Mon, 15 Oct 2007 21:59:49 +0900	[thread overview]
Message-ID: <20071015215949.50399c00.komurojun-mbn@nifty.com> (raw)
In-Reply-To: <20071014135356.19754635.komurojun-mbn@nifty.com>

Dear shemminger

>In which case it is zero because that is the default value.

The default value of snd_ssthresh is 0x7fffffff, isn't it?

[linux/net/ipv4/tcp_ipv4.c]
static int tcp_v4_init_sock(struct sock *sk)
...
        tp->snd_ssthresh = 0x7fffffff;  /* Infinity */
...

Best Regards
Komuro


> 
> Actually, tcp_sk(sk)->snd_ssthresh is not initialized,
> if initial_ssthresh is 0.
> 
> The patch should be
> 
>  static void bictcp_init(struct sock *sk)
>  {
>  	bictcp_reset(inet_csk_ca(sk));
> -	if (initial_ssthresh)
> -		tcp_sk(sk)->snd_ssthresh = initial_ssthresh;
> +
> +	tcp_sk(sk)->snd_ssthresh = initial_ssthresh;
>  }
>

  parent reply	other threads:[~2007-10-15 13:01 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-06  4:26 [PATCH] Simplify yenta code Komuro
2007-10-08 17:47 ` Linas Vepstas
2007-10-13 22:36 ` [NOT VERY SAFE] [TCP]: Set initial_ssthresh default to zero in Cubic and BIC Komuro
2007-10-13 22:52   ` David Miller
2007-10-13 22:54     ` David Miller
2007-10-14  1:02   ` Komuro
2007-10-14  2:38     ` David Miller
2007-10-14  4:30       ` Jeff Garzik
2007-10-14  4:28     ` Komuro
2007-10-14  4:32       ` David Miller
2007-10-14  4:53       ` Komuro
2007-10-14  5:23         ` David Miller
2007-10-15 12:59         ` Komuro [this message]
2007-10-15 15:55           ` Stephen Hemminger
2007-10-14 20:34     ` Stephen Hemminger
2008-03-02 12:07   ` [BUG kernel 2.6.25-rc3 IPV6] ping6 -I eth0 ff02::1 causes system hang Komuro
2008-03-04  7:40     ` Andrew Morton
2008-03-08  4:44     ` Komuro
2008-03-08  5:20       ` Komuro
2008-03-08 11:56       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071015215949.50399c00.komurojun-mbn@nifty.com \
    --to=komurojun-mbn@nifty.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@linux.foundation.org \
    --subject='Re: [NOT VERY SAFE]     [TCP]: Set initial_ssthresh default to zero in Cubic and BIC.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).