LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: Shane.Huang@amd.com
Cc: gregkh@suse.de, htejun@gmail.com, linux-kernel@vger.kernel.org,
linux-pci@atrey.karlin.mff.cuni.cz, Henry.Su@amd.com,
Libin.Yang@amd.com
Subject: Re: [patch] PCI: disable MSI on more ATI NorthBridges
Date: Thu, 18 Oct 2007 03:19:57 -0700 (PDT) [thread overview]
Message-ID: <20071018.031957.104033396.davem@davemloft.net> (raw)
In-Reply-To: <5CAB7B5D6F8AB84AA868A46B47A507055D8C1D@sshaexmb1.amd.com>
From: "Shane Huang" <Shane.Huang@amd.com>
Date: Thu, 18 Oct 2007 17:14:36 +0800
> More ATI North Bridges like RS780 can't do MSI like its predecessors
> in linux. Disable MSIs on them.
>
> Signed-off-by: Shane Huang <shane.huang@amd.com>
Can we get some detail as to why these north bridges have to have MSI
disabled completely? I can't believe that all 6 of these ATI
controllers which will now be listed in the quirk table cannot use MSI
at all.
I've discovered several cases where it was a buggy device or a driver
bug that caused someone to erroneously submit patches that disable MSI
completely for the bridge they were behind.
I don't want that to happen any more. One way to prevent that is to
have a full detailed justification for the MSI disabling in the
changelog or in the comments for the MSI quirk.
Thank you.
next prev parent reply other threads:[~2007-10-18 10:19 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-18 9:14 Shane Huang
2007-10-18 10:19 ` David Miller [this message]
2007-10-18 10:37 ` Shane Huang
2007-10-18 11:46 ` David Miller
2007-10-18 15:24 ` Greg KH
2007-10-19 17:42 ` Daniel Barkalow
2008-01-24 10:59 ` [patch] PCI: disable the MSI of AMD RS690 Shane Huang
2008-01-24 11:12 ` [patch] PCI: modify SB700 SATA MSI quirk Shane Huang
2008-01-25 0:19 ` Tejun Heo
2008-01-25 3:26 ` Shane Huang
2008-01-25 3:35 ` Tejun Heo
2008-01-25 3:48 ` Shane Huang
2008-01-25 4:33 ` Greg KH
2008-01-24 11:15 ` [patch] PCI: disable the MSI of AMD RS690 Brice Goglin
2008-01-25 10:39 ` Shane Huang
2007-10-19 13:17 [patch] PCI: disable MSI on more ATI NorthBridges Shane Huang
2007-10-19 19:57 ` Linas Vepstas
2007-10-19 20:21 ` Jeff Garzik
2007-10-20 22:03 ` Benjamin Herrenschmidt
2007-10-22 20:26 ` Daniel Barkalow
2007-10-22 20:41 ` Jeff Garzik
2007-10-22 21:31 ` Daniel Barkalow
2007-10-22 23:48 ` Krzysztof Halasa
2007-10-23 0:13 ` David Miller
2007-10-23 5:52 ` Daniel Barkalow
2007-10-23 9:39 ` Shane Huang
2007-10-23 10:01 ` Jeff Garzik
2007-10-23 10:06 ` David Miller
2007-10-24 2:46 ` David Miller
2007-10-23 10:15 ` Jeff Garzik
2007-10-22 23:40 ` Krzysztof Halasa
2007-10-22 23:58 ` David Miller
2007-10-23 10:13 ` Jeff Garzik
2007-10-20 14:50 ` Shane Huang
2007-10-20 20:52 ` David Gaarenstroom
2007-10-21 6:00 ` Shane Huang
2007-10-23 10:56 ` Shane Huang
2007-10-24 2:41 ` David Miller
2007-10-24 6:53 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071018.031957.104033396.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Henry.Su@amd.com \
--cc=Libin.Yang@amd.com \
--cc=Shane.Huang@amd.com \
--cc=gregkh@suse.de \
--cc=htejun@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--subject='Re: [patch] PCI: disable MSI on more ATI NorthBridges' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).