LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ivo van Doorn <ivdoorn@gmail.com>
To: rt2400-devel@lists.sourceforge.net
Cc: Pavel Machek <pavel@ucw.cz>,
	kernel list <linux-kernel@vger.kernel.org>,
	linux-wireless@vger.kernel.org, mwallis@serialmonkey.com
Subject: Re: [Rt2400-devel] rt73usb: support for wireless in Kohjinsha subnotebook
Date: Sun, 21 Oct 2007 00:12:36 +0200	[thread overview]
Message-ID: <200710210012.37547.IvDoorn@gmail.com> (raw)
In-Reply-To: <20071020184100.GA11640@elf.ucw.cz>

Hi,

> Kohjinsha subnotebook seems to contain wifi with USB IDs 0x18e8,
> 0x6206... I hope that to be compatible with
> net/wireless/rt2x00/rt73usb.c .

Is there any reason you assume it is a rt73usb device,
or are you just making wild guesses about what the chipset is?

> [Sidenote: could we add some real author info into rt73usb.c?]

You mean expanding the project name to the full list of developers in
the project? I don't see any need for that.

> I did this on 2.6.23-rc8-mm1 kernel (The RT hack may not be
> neccessary), but then it oopses somewhere in softmac layer. I'll try
> to play with it some more.
> 
> If you have any ideas, let me know.
> 								Pavel
> 
> --- clean-mm/drivers/net/wireless/rt2x00/rt73usb.c	2007-10-09 09:32:08.000000000 +0200
> +++ linux-mm/drivers/net/wireless/rt2x00/rt73usb.c	2007-10-19 22:19:45.000000000 +0200
> @@ -1580,7 +1580,6 @@
>  
>  	if (!rt2x00_rev(&rt2x00dev->chip, 0x25730)) {
>  		ERROR(rt2x00dev, "Invalid RT chipset detected.\n");
> -		return -ENODEV;
>  	}
>  
>  	if (!rt2x00_rf(&rt2x00dev->chip, RF5226) &&
> @@ -1588,7 +1587,6 @@
>  	    !rt2x00_rf(&rt2x00dev->chip, RF5225) &&
>  	    !rt2x00_rf(&rt2x00dev->chip, RF2527)) {
>  		ERROR(rt2x00dev, "Invalid RF chipset detected.\n");
> -		return -ENODEV;
>  	}

Both removals of -ENODEV are completely wrong. If the device does not pass the above
2 checks it is _not_ a rt73usb device. And forcing the driver to work with the device will
result in all kinds of problems.

If rt2x00 is loaded and detected the device, it should print out a debug message that starts with:
"Chipset detected - " What is in your case the complete line?

Ivo

  reply	other threads:[~2007-10-21  1:52 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-20 18:41 Pavel Machek
2007-10-20 22:12 ` Ivo van Doorn [this message]
2007-10-21  9:20   ` [Rt2400-devel] " Pavel Machek
2007-10-21 13:56     ` Ivo van Doorn
2007-10-21  9:21   ` Pavel Machek
2007-10-21 13:49     ` Ivo van Doorn
2007-10-21 11:38       ` Pavel Machek
2007-10-21 14:09         ` Ivo van Doorn
2007-10-21 11:58           ` Luis Correia
2007-10-21 15:02 ` Luis Correia
2007-10-21 20:04   ` ISSC W89C35 802.11bg (was Re: rt73usb: support for wireless in Kohjinsha subnotebook) Pavel Machek
2007-10-22  0:09   ` rt73usb: support for wireless in Kohjinsha subnotebook Pavel Machek
2007-10-22 15:44     ` Dan Williams
2007-10-22 21:13       ` Pavel Machek
2007-10-22 21:52         ` Ivo van Doorn
2007-10-22 21:42           ` Daniel Hazelton
2007-10-22 22:00             ` Pavel Machek
2007-10-23  9:08               ` Christoph Hellwig
2007-10-23  9:11                 ` Luis Correia
2007-10-30 11:22                 ` Licensing of IS89C35 WLAN USB driver [was Re: rt73usb: support for wireless in Kohjinsha subnotebook] Pavel Machek
2007-10-30 15:11                   ` Dan Williams
2007-10-31  0:25                     ` Pavel Machek
2007-11-04 19:00                     ` Pavel Machek
2007-10-23 14:05               ` rt73usb: support for wireless in Kohjinsha subnotebook Dan Williams
2007-10-23 17:07                 ` Daniel Hazelton
2007-10-23 18:54                   ` Dan Williams
2007-10-23 19:41                     ` Daniel Hazelton
2007-10-23 21:27                       ` Dan Williams
2007-10-23 22:19                         ` Daniel Hazelton
2007-10-23 16:13           ` Arjan van de Ven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200710210012.37547.IvDoorn@gmail.com \
    --to=ivdoorn@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mwallis@serialmonkey.com \
    --cc=pavel@ucw.cz \
    --cc=rt2400-devel@lists.sourceforge.net \
    --subject='Re: [Rt2400-devel] rt73usb: support for wireless in Kohjinsha subnotebook' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).