[PATCH 5/5] NET: Remove unneeded implicit type case when calling tcp_minshall_update()

[PATCH 5/5] NET: Remove unneeded implicit type case when calling tcp_minshall_update()

[Chuck Lever]

The tcp_minshall_update() function is called in exactly one place, and is
passed an unsigned integer for the mss_len argument.  Make the sign of the
argument match the sign of the passed variable in order to eliminate an
unneeded implicit type cast and a mixed sign comparison in
tcp_minshall_update().

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Cc: <netdev@vger.kernel.org>
---

 include/net/tcp.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/net/tcp.h b/include/net/tcp.h
index 92049e6..d695cea 100644
--- a/include/net/tcp.h
+++ b/include/net/tcp.h
@@ -803,7 +803,7 @@ static inline int tcp_is_cwnd_limited(const struct sock *sk, u32 in_flight)
 		return left <= tcp_max_burst(tp);
 }
 
-static inline void tcp_minshall_update(struct tcp_sock *tp, int mss,
+static inline void tcp_minshall_update(struct tcp_sock *tp, unsigned int mss,
 				       const struct sk_buff *skb)
 {
 	if (skb->len < mss)

Re: [PATCH 5/5] NET: Remove unneeded implicit type case when calling tcp_minshall_update()

[David Miller]

From: Chuck Lever <chuck.lever@oracle.com>
Date: Tue, 23 Oct 2007 11:44:33 -0400

> The tcp_minshall_update() function is called in exactly one place, and is
> passed an unsigned integer for the mss_len argument.  Make the sign of the
> argument match the sign of the passed variable in order to eliminate an
> unneeded implicit type cast and a mixed sign comparison in
> tcp_minshall_update().
> 
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>

Applied, thanks.

> Cc: <netdev@vger.kernel.org>

Actually, you only CC:'d linux-kernel on these patches.