LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] 9p: v9fs_vfs_rename incorrect clunk order
@ 2007-10-23  0:14 Latchesar Ionkov
  2007-10-23 22:30 ` [V9fs-developer] " Eric Van Hensbergen
  0 siblings, 1 reply; 2+ messages in thread
From: Latchesar Ionkov @ 2007-10-23  0:14 UTC (permalink / raw)
  To: v9fs-developer; +Cc: linux-fsdevel, linux-kernel

In v9fs_vfs_rename function labels don't match the fids that are clunked.
The correct clunk order is clunking newdirfid first and then olddirfid next.

Signed-off-by: Latchesar Ionkov <lucho@ionkov.net>

---
commit 0c9269a1384273b7a409a2163fdf91cd39092889
tree 8a4984196ccb7ed027c086a53866e5582835e61f
parent 55b70a0300b873c0ec7ea6e33752af56f41250ce
author Latchesar Ionkov <lucho@ionkov.net> Mon, 22 Oct 2007 18:11:19 -0600
committer Latchesar Ionkov <lucho@ionkov.net> Mon, 22 Oct 2007 18:11:19 -0600

 fs/9p/vfs_inode.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/9p/vfs_inode.c b/fs/9p/vfs_inode.c
index 175b4d9..23581bc 100644
--- a/fs/9p/vfs_inode.c
+++ b/fs/9p/vfs_inode.c
@@ -687,10 +687,10 @@ v9fs_vfs_rename(struct inode *old_dir, struct dentry *old_dentry,
 	retval = p9_client_wstat(oldfid, &wstat);
 
 clunk_newdir:
-	p9_client_clunk(olddirfid);
+	p9_client_clunk(newdirfid);
 
 clunk_olddir:
-	p9_client_clunk(newdirfid);
+	p9_client_clunk(olddirfid);
 
 done:
 	return retval;

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [V9fs-developer] [PATCH] 9p: v9fs_vfs_rename incorrect clunk order
  2007-10-23  0:14 [PATCH] 9p: v9fs_vfs_rename incorrect clunk order Latchesar Ionkov
@ 2007-10-23 22:30 ` Eric Van Hensbergen
  0 siblings, 0 replies; 2+ messages in thread
From: Eric Van Hensbergen @ 2007-10-23 22:30 UTC (permalink / raw)
  To: Latchesar Ionkov; +Cc: v9fs-developer, linux-fsdevel, linux-kernel

On 10/22/07, Latchesar Ionkov <lucho@ionkov.net> wrote:
> In v9fs_vfs_rename function labels don't match the fids that are clunked.
> The correct clunk order is clunking newdirfid first and then olddirfid next.
>
> Signed-off-by: Latchesar Ionkov <lucho@ionkov.net>
Acked-by: Eric Van Hensbergen <ericvh@gmail.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-10-23 22:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-10-23  0:14 [PATCH] 9p: v9fs_vfs_rename incorrect clunk order Latchesar Ionkov
2007-10-23 22:30 ` [V9fs-developer] " Eric Van Hensbergen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).