LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Adrian Bunk <bunk@kernel.org>
To: "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: Ralf Baechle <ralf@linux-mips.org>,
	Franck Bui-Huu <vagabon.xyz@gmail.com>,
	linux-arch@vger.kernel.org, linux-mips@linux-mips.org,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Discardable strings for init and exit sections
Date: Tue, 23 Oct 2007 19:12:02 +0200	[thread overview]
Message-ID: <20071023171201.GW30533@stusta.de> (raw)
In-Reply-To: <Pine.LNX.4.64N.0710231753250.8693@blysk.ds.pg.gda.pl>

On Tue, Oct 23, 2007 at 05:57:38PM +0100, Maciej W. Rozycki wrote:
> On Fri, 12 Oct 2007, Adrian Bunk wrote:
> 
> > - Most of the string annotations are (naturally) dev{init,exit}
> >   annotations, and bugs there are therefore in configurations that have
> >   only extremely low testing coverage during -rc.
> > - I'm counting 22 annotations in the driver Maciej converted as an
> >   example. When estimating the number of possible annotations based
> >   on the number of C files in the kernel I'm getting a six digit
> >   number.
> > 
> > No matter how hard it would be to teach gcc about it, when thinking of 
> > the amount of __*init*/__*exit* bugs we already have I simply can't 
> > imagine the string annotations as a maintainable solution.
> 
>  Well, it is up to the maintainer of code in question to get it right if 
> interested.  Otherwise having no annotation and leaving the relevant 
> strings resident in the memory throughout the lifespan of the system is a 
> valid and perfectly working option.

If we want to go this route users may want to have this for all code 
they are using. This is not a per-maintainer question, that's a global 
thing: If janitors start annotating all source files in the kernel the 
resulting patches can't be accepted or rejected only based on the 
personal preferences of the maintainers.

>  If you worry about the reverse case, where an annotation should be 
> removed because the containing function is no longer __*init*/__*exit*, 
> then I think `modpost' does a reasonably good job finding such places.

As long as the modpost warnings are just warnings they will often be 
missed at compile time.

And most of the annotations (also in the driver you converted as an 
example) will be dev{init,exit} annotations, and bugs there are in 
configurations virtually noone tests during -rc

>   Maciej

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


  reply	other threads:[~2007-10-23 17:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-12 16:50 Maciej W. Rozycki
2007-10-12 17:19 ` Adrian Bunk
2007-10-12 17:52   ` Ralf Baechle
2007-10-12 18:15     ` Adrian Bunk
2007-10-23 16:57       ` Maciej W. Rozycki
2007-10-23 17:12         ` Adrian Bunk [this message]
2007-10-23 17:25           ` Sam Ravnborg
2007-10-12 17:45 ` Sam Ravnborg
2007-10-23 17:23   ` Maciej W. Rozycki
2007-10-23 17:27     ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071023171201.GW30533@stusta.de \
    --to=bunk@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=macro@linux-mips.org \
    --cc=ralf@linux-mips.org \
    --cc=vagabon.xyz@gmail.com \
    --subject='Re: [PATCH] Discardable strings for init and exit sections' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).