LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: Rodolfo Giometti <giometti@enneenne.com>
Cc: linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] LinuxPPS - PPS support for Linux
Date: Tue, 23 Oct 2007 16:17:50 -0400	[thread overview]
Message-ID: <20071023201750.GE7793@redhat.com> (raw)
In-Reply-To: <20071023180417.GM9748@enneenne.com>

On Tue, Oct 23, 2007 at 08:04:18PM +0200, Rodolfo Giometti wrote:

Hi Rodolfo,
 
 > here my last patch for PPS support.
 > 
 > Please, let me know if I have something to do for kernel inclusion.

Thanks for trying to get this merged, we've had a few users asking
us to support this in the Fedora kernel.

>From a quick look through, it doesn't look too bad.
A couple of obvious things that jumped out..

* The example program in the Documentation dir.
  There was some discussion recently about moving away 
  from doing this, and instead moving code to the samples/ dir
  (or including it in util-linux instead if applicable).

 > +    static struct pps_source_info_s pps_ktimer_info = {
 > +            name         : "ktimer",
 > +            path         : "",
 > +            mode         : PPS_CAPTUREASSERT | PPS_OFFSETASSERT | \
 > +			   PPS_ECHOASSERT | \
 > +                           PPS_CANWAIT | PPS_TSFMT_TSPEC,
 > +            echo         : pps_ktimer_echo,
 > +            owner        : THIS_MODULE,
 > +    };

  should be
    .name = "ktimer"
  etc..

 > +#include <linux/version.h>

This should be getting included automatically for you.

On the whole, asides from these (very) minor nits, quite a clean
submission compared to a lot of new driver submissions to lkml.
Might want to run it through scripts/checkpatch.pl too to see
if that picks up any more minor fluff.

	Dave

-- 
http://www.codemonkey.org.uk

  reply	other threads:[~2007-10-23 20:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-23 18:04 Rodolfo Giometti
2007-10-23 20:17 ` Dave Jones [this message]
2007-10-23 20:35   ` Rodolfo Giometti
2007-10-23 20:55   ` Rodolfo Giometti
2007-10-23 21:08     ` Roland Dreier
2007-10-24  7:00       ` Rodolfo Giometti
2007-10-25  8:39       ` Rodolfo Giometti
2007-10-25 20:32         ` Rodolfo Giometti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071023201750.GE7793@redhat.com \
    --to=davej@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=dwmw2@infradead.org \
    --cc=giometti@enneenne.com \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH] LinuxPPS - PPS support for Linux' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).