[PATCH v2] Fix a build error when BLOCK=n

[PATCH v2] Fix a build error when BLOCK=n

[Emil Medve]

mm/filemap.c: In function '__filemap_fdatawrite_range':
mm/filemap.c:200: error: implicit declaration of function 'mapping_cap_writeback_dirty'

This happens when we don't use/have any block devices and a NFS root filesystem
is used

mapping_cap_writeback_dirty() is defined in linux/backing-dev.h which used to be
provided in mm/filemap.c by linux/blkdev.h until commit
f5ff8422bbdd59f8c1f699df248e1b7a11073027

Signed-off-by: Emil Medve <Emilian.Medve@Freescale.com>
---

This is against Linus' tree: d85714d81cc0408daddb68c10f7fd69eafe7c213

linux-2.6> scripts/checkpatch.pl 0001-Fix-a-build-error-when-BLOCK-n.patch 
Your patch has no obvious style problems and is ready for submission.

 mm/filemap.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/mm/filemap.c b/mm/filemap.c
index 79f24a9..61efe94 100644
--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -27,6 +27,7 @@
 #include <linux/writeback.h>
 #include <linux/pagevec.h>
 #include <linux/blkdev.h>
+#include <linux/backing-dev.h>
 #include <linux/security.h>
 #include <linux/syscalls.h>
 #include <linux/cpuset.h>
-- 
1.5.3.GIT

Re: [PATCH v2] Fix a build error when BLOCK=n

[Jens Axboe]

On Thu, Oct 18 2007, Emil Medve wrote:
> mm/filemap.c: In function '__filemap_fdatawrite_range':
> mm/filemap.c:200: error: implicit declaration of function 'mapping_cap_writeback_dirty'
> 
> This happens when we don't use/have any block devices and a NFS root filesystem
> is used
> 
> mapping_cap_writeback_dirty() is defined in linux/backing-dev.h which used to be
> provided in mm/filemap.c by linux/blkdev.h until commit
> f5ff8422bbdd59f8c1f699df248e1b7a11073027
> 
> Signed-off-by: Emil Medve <Emilian.Medve@Freescale.com>

Acked-by: Jens Axboe <jens.axboe@oracle.com>

-- 
Jens Axboe

RE: [PATCH v2] Fix a build error when BLOCK=n

[Medve Emilian-EMMEDVE1]

Hello Jens,


In who's tree would this go?


Thanks,
Emil.


> -----Original Message-----
> From: Jens Axboe [mailto:jens.axboe@oracle.com] 
> Sent: Thursday, October 18, 2007 10:27 AM
> To: Medve Emilian-EMMEDVE1
> Cc: linux-kernel@vger.kernel.org; linux-mm@kvack.org; 
> torvalds@linux-foundation.org
> Subject: Re: [PATCH v2] Fix a build error when BLOCK=n
> 
> On Thu, Oct 18 2007, Emil Medve wrote:
> > mm/filemap.c: In function '__filemap_fdatawrite_range':
> > mm/filemap.c:200: error: implicit declaration of function 
> 'mapping_cap_writeback_dirty'
> > 
> > This happens when we don't use/have any block devices and a 
> NFS root filesystem
> > is used
> > 
> > mapping_cap_writeback_dirty() is defined in 
> linux/backing-dev.h which used to be
> > provided in mm/filemap.c by linux/blkdev.h until commit
> > f5ff8422bbdd59f8c1f699df248e1b7a11073027
> > 
> > Signed-off-by: Emil Medve <Emilian.Medve@Freescale.com>
> 
> Acked-by: Jens Axboe <jens.axboe@oracle.com>
> 
> -- 
> Jens Axboe

Re: [PATCH v2] Fix a build error when BLOCK=n

[Jens Axboe]

On Tue, Oct 23 2007, Medve Emilian-EMMEDVE1 wrote:
> Hello Jens,
> 
> 
> In who's tree would this go?

I'll add it to the block tree.

-- 
Jens Axboe