LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Al Viro <viro@ftp.linux.org.uk>
To: Matt Mackall <mpm@selenic.com>
Cc: linux-kernel@vger.kernel.org,
	"Eric W. Biederman" <ebiederm@xmission.com>
Subject: Re: [RFC] what the hell is going on with /proc/self?
Date: Tue, 23 Oct 2007 21:42:15 +0100	[thread overview]
Message-ID: <20071023204215.GD8181@ftp.linux.org.uk> (raw)
In-Reply-To: <20071023202039.GK17536@waste.org>

On Tue, Oct 23, 2007 at 03:20:39PM -0500, Matt Mackall wrote:
> On Tue, Oct 23, 2007 at 03:03:36AM +0100, Al Viro wrote:
> > 	What is the proc_base_stuff[] nonsense about?  AFAICS, that
> > went in with no reason whatsoever in
> > commit 801199ce805a2412bbcd9bfe213092ec656013dd
> > Author: Eric W. Biederman <ebiederm@xmission.com>
> > Date:   Mon Oct 2 02:18:48 2006 -0700
> > 
> > 	Rationale is very weak and patch adds considerable complexity
> > for no good reason.  Besides, it's obfuscated just for the hell of it:
> > 	if (!IS_ERR(result) || PTR_ERR(result) != -ENOENT)
> > instead of
> > 	if (result != ERR_PTR(-ENOENT))
> > etc.
> > 
> > 	Unless there are _real_ plans that would justify that animal,
> > I'm going to get rid of it in the pending patch series (/proc/self
> > cleanups, saner dentry retention for non-process parts, etc.).
> 
> Seems obvious to cc: Eric.

Doh...  Sorry, thought I'd done that.  Eric, my apologies.

  reply	other threads:[~2007-10-23 20:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-23  2:03 Al Viro
2007-10-23 20:20 ` Matt Mackall
2007-10-23 20:42   ` Al Viro [this message]
2007-10-24  2:57     ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071023204215.GD8181@ftp.linux.org.uk \
    --to=viro@ftp.linux.org.uk \
    --cc=ebiederm@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpm@selenic.com \
    --subject='Re: [RFC] what the hell is going on with /proc/self?' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).