LKML Archive on
help / color / mirror / Atom feed
From: Ralf Baechle <>
To: Bjorn Helgaas <>
Cc: Alessandro Zummo <>,
	Andrew Morton <>,,
Subject: Re: [patch 1/2] rtc: release correct region in error path
Date: Wed, 24 Oct 2007 16:12:50 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Tue, Oct 23, 2007 at 02:48:44PM -0600, Bjorn Helgaas wrote:

> Subject: [patch 1/2] rtc: release correct region in error path
> The misc_register() error path always released an I/O port region,
> even if the region was memory-mapped (only mips uses memory-mapped RTC,
> as far as I can see).

Well, MIPS just like other sane architectures has no concept of ioports.
So if there ever is something that's called an ioport on MIPS then it's
really a memory location in a memory address range where other PCish
devices are living, too.  So typically those memory addresses are
translated to an actual ioport access by a PCI bridge.  There are a few
systems where this concept just apply easily such as DECstations, so
there we simply claim the device such as the RTC in this case is memory


Acked-by: Ralf Baechle <>


  reply	other threads:[~2007-10-24 15:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-23 20:48 [patch 0/2] RTC fixes Bjorn Helgaas
2007-10-23 20:48 ` [patch 1/2] rtc: release correct region in error path Bjorn Helgaas
2007-10-24 15:12   ` Ralf Baechle [this message]
2007-10-23 20:48 ` [patch 2/2] rtc: fallback to requesting only the ports we actually use Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \
    --subject='Re: [patch 1/2] rtc: release correct region in error path' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).