LKML Archive on
help / color / mirror / Atom feed
From: Grant Grundler <>
To: Greg KH <>
Cc: Barak Fargoun <>,,,
	Guy Zana <>
Subject: Re: [PATCH] Align PCI memory regions to page size (4K) - Fix
Date: Sun, 28 Oct 2007 23:52:16 -0600	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Sun, Oct 28, 2007 at 01:03:36PM -0700, Greg KH wrote:
> On Sun, Oct 28, 2007 at 03:53:20PM -0400, Barak Fargoun wrote:
> > About your question: today, some of the hypervisors are using linux
> > kernel as their domain-0 (e.g. Xen). In order to implement direct
> > hardware access for these native domains (e.g.  running windows in a
> > virtual machine above Xen), the PCI memory regions should be aligned
> > at-least at the page-level (so, a virtual machine - can't see data of
> > other devices which may not be assigned to it). So, for that reason,
> > we wanted a boot parameter to let us force the kernel to align PCI
> > memory regions at-least at a PAGE_SIZE alignment. It is very useful
> > for hypervisors which are developed at Linux environment (e.g.: Xen).
> And if not, why would we not do this for all devices not just for
> virtual machines, if it is such a benefit?

It's a benefit IFF multiple devices are spread across more than one guest
_and_ we don't trust every particating guest to play nicely with IO.  That way
the Hypervisor can assign one device to a specific guest OS for direct access.
E.g. 4 port Gige card could directly support the host and 3 guests with somewhat
lower risk of tromping on each other's MMIO space.

If Xen is cooperative, this seems a bit paranoid. I don't recall ever seeing a
driver bug where the driver accidentally poked MMIO space at the wrong device.
That's much more common for IO Port space. The only exception was xfree86 where it
poked around in random places to deal with buggy HW quirks.

The use of an IOMMU will provide much more useful protection.


  parent reply	other threads:[~2007-10-29  5:52 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-28 17:27 Barak Fargoun
2007-10-28 19:31 ` Greg KH
2007-10-28 19:53   ` Barak Fargoun
2007-10-28 20:03     ` Greg KH
2007-10-28 20:44       ` Barak Fargoun
2007-10-29  1:08       ` David Miller
2007-11-13 21:17         ` Benjamin Herrenschmidt
2007-11-14  6:21           ` Grant Grundler
2007-11-14  8:16             ` Benjamin Herrenschmidt
2007-11-14 21:55               ` Grant Grundler
2007-11-14 22:16                 ` Benjamin Herrenschmidt
2007-10-29  5:52       ` Grant Grundler [this message]
2007-11-08 23:24         ` Linas Vepstas
2007-11-12 23:43           ` Grant Grundler
2007-10-28 19:48 ` Arjan van de Ven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] Align PCI memory regions to page size (4K) - Fix' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).