LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Aristeu Rozanski <aris@ruivo.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Truxton Fulton <trux@truxton.com>,
	Hiroto Shibuya <hiroto.shibuya@gmail.com>,
	Lee Garrett <lee-in-berlin@web.de>,
	linux-kernel@vger.kernel.org,
	"bugme-daemon@kernel-bugs.osdl.org" 
	<bugme-daemon@bugzilla.kernel.org>,
	ak@suse.de, torvalds@osdl.org
Subject: Re: [Bugme-new] [Bug 8378] New: Averatec 3156X laptop doesn't reboot with kernels > 2.6.13.5 (responsible commit found)
Date: Thu, 1 Nov 2007 11:50:31 -0400	[thread overview]
Message-ID: <20071101155031.GB8068@cathedrallabs.org> (raw)
In-Reply-To: <m2sl4tyloc.fsf@truxton.com>

Hi Andrew,
> > OK, thanks.
> > 
> > So that are we doing here?  We try the pre-Truxton code and if that didn't
> > work we try the post-Truxton code?  Hard to see how that could go wrong.
> > 
> > Truxton, can you please test it for us?
> 
> Hiroto Shibuya wrote to tell me that he has a VIA EPIA-EK10000
> which suffers from the reboot problem when no keyboard is attached.
> My first patch works for him :
> 
>   http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=59f4e7d572980a521b7bdba74ab71b21f5995538
> 
> But the latest patch does not work for him :
> 
>   http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=8b93789808756bcc1e5c90c99f1b1ef52f839a51
> 
> We found that it was necessary to also set the "disable keyboard"
> flag in the command byte, as the first patch was doing.  The
> second patch tries to minimally modify the command byte, but
> it is not enough.
> 
> Please consider this simple one-line patch to help people with
> low end VIA motherboards reboot when no keyboard is attached.
> Hiroto Shibuya has verified that this works for him (as I
> no longer have an afflicted machine) :
> 
> This patch is against linux-2.6.23-rc9/include/asm-i386/mach-default/mach_reboot.h
> 
> --- mach_reboot.h       Mon Oct  1 20:24:52 2007
> +++ mach_reboot.h.new   Tue Oct  2 19:22:13 2007
> @@ -49,7 +49,7 @@
>                 udelay(50);
>                 kb_wait();
>                 udelay(50);
> -               outb(cmd | 0x04, 0x60); /* set "System flag" */
> +               outb(cmd | 0x14, 0x60); /* set "System flag" and "Keyboard Disabled" */
>                 udelay(50);
>                 kb_wait();
>                 udelay(50);
> 
> 
any chance to get this into next -mm?

-- 
Aristeu


  reply	other threads:[~2007-11-01 16:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200704271742.l3RHgPTH019561@fire-2.osdl.org>
2007-04-27 21:44 ` Andrew Morton
2007-04-28  3:17   ` Truxton Fulton
2007-05-12 19:35     ` Lee Garrett
2007-05-13  1:02       ` Andrew Morton
2007-05-13 12:13         ` Truxton Fulton
2007-10-03  2:30         ` Truxton Fulton
2007-11-01 15:50           ` Aristeu Rozanski [this message]
2007-11-01 17:53             ` Andrew Morton
2007-11-01 18:05               ` Aristeu Rozanski
2007-04-28 11:23   ` Segher Boessenkool

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071101155031.GB8068@cathedrallabs.org \
    --to=aris@ruivo.org \
    --cc=ak@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=bugme-daemon@bugzilla.kernel.org \
    --cc=hiroto.shibuya@gmail.com \
    --cc=lee-in-berlin@web.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    --cc=trux@truxton.com \
    --subject='Re: [Bugme-new] [Bug 8378] New: Averatec 3156X laptop doesn'\''t reboot with kernels > 2.6.13.5 (responsible commit found)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).