LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] Fix warning for token-ring from sysctl checker
@ 2007-11-13  7:23 Olof Johansson
  2007-11-14  5:15 ` David Miller
  0 siblings, 1 reply; 6+ messages in thread
From: Olof Johansson @ 2007-11-13  7:23 UTC (permalink / raw)
  To: akpm; +Cc: netdev, linux-kernel, Eric W. Biederman

As seen when booting ppc64_defconfig:

sysctl table check failed: /net/token-ring .3.14 procname does not match binary path procname


Signed-off-by: Olof Johansson <olof@lixom.net>

diff --git a/kernel/sysctl_check.c b/kernel/sysctl_check.c
index 5a2f2b2..4abc6d2 100644
--- a/kernel/sysctl_check.c
+++ b/kernel/sysctl_check.c
@@ -738,7 +738,7 @@ static struct trans_ctl_table trans_net_table[] = {
 	{ NET_ROSE,		"rose",		trans_net_rose_table },
 	{ NET_IPV6,		"ipv6",		trans_net_ipv6_table },
 	{ NET_X25,		"x25",		trans_net_x25_table },
-	{ NET_TR,		"tr",		trans_net_tr_table },
+	{ NET_TR,		"token-ring",	trans_net_tr_table },
 	{ NET_DECNET,		"decnet",	trans_net_decnet_table },
 	/*  NET_ECONET not used */
 	{ NET_SCTP,		"sctp",		trans_net_sctp_table },

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] Fix warning for token-ring from sysctl checker
  2007-11-13  7:23 [PATCH] Fix warning for token-ring from sysctl checker Olof Johansson
@ 2007-11-14  5:15 ` David Miller
  2007-11-14 15:56   ` Eric W. Biederman
  0 siblings, 1 reply; 6+ messages in thread
From: David Miller @ 2007-11-14  5:15 UTC (permalink / raw)
  To: olof; +Cc: akpm, netdev, linux-kernel, ebiederm

From: Olof Johansson <olof@lixom.net>
Date: Tue, 13 Nov 2007 01:23:13 -0600

> As seen when booting ppc64_defconfig:
> 
> sysctl table check failed: /net/token-ring .3.14 procname does not match binary path procname
> 
> 
> Signed-off-by: Olof Johansson <olof@lixom.net>

Patch applied, thanks Olof.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] Fix warning for token-ring from sysctl checker
  2007-11-14  5:15 ` David Miller
@ 2007-11-14 15:56   ` Eric W. Biederman
  2007-11-14 16:45     ` Randy Dunlap
  0 siblings, 1 reply; 6+ messages in thread
From: Eric W. Biederman @ 2007-11-14 15:56 UTC (permalink / raw)
  To: David Miller; +Cc: olof, akpm, netdev, linux-kernel

David Miller <davem@davemloft.net> writes:

> From: Olof Johansson <olof@lixom.net>
> Date: Tue, 13 Nov 2007 01:23:13 -0600
>
>> As seen when booting ppc64_defconfig:
>> 
>> sysctl table check failed: /net/token-ring .3.14 procname does not match
> binary path procname
>> 
>> 
>> Signed-off-by: Olof Johansson <olof@lixom.net>
>
> Patch applied, thanks Olof.

No objections but I think we already have this fixed in the -mm tree.

Eric


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] Fix warning for token-ring from sysctl checker
  2007-11-14 15:56   ` Eric W. Biederman
@ 2007-11-14 16:45     ` Randy Dunlap
  2007-11-15  0:28       ` Olof Johansson
  0 siblings, 1 reply; 6+ messages in thread
From: Randy Dunlap @ 2007-11-14 16:45 UTC (permalink / raw)
  To: Eric W. Biederman; +Cc: David Miller, olof, akpm, netdev, linux-kernel

On Wed, 14 Nov 2007 08:56:20 -0700 Eric W. Biederman wrote:

> David Miller <davem@davemloft.net> writes:
> 
> > From: Olof Johansson <olof@lixom.net>
> > Date: Tue, 13 Nov 2007 01:23:13 -0600
> >
> >> As seen when booting ppc64_defconfig:
> >> 
> >> sysctl table check failed: /net/token-ring .3.14 procname does not match
> > binary path procname
> >> 
> >> 
> >> Signed-off-by: Olof Johansson <olof@lixom.net>
> >
> > Patch applied, thanks Olof.
> 
> No objections but I think we already have this fixed in the -mm tree.

Yes, I patched it several weeks ago and it's been in -mm for a while
now.  Apparently too long.

---
~Randy

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] Fix warning for token-ring from sysctl checker
  2007-11-14 16:45     ` Randy Dunlap
@ 2007-11-15  0:28       ` Olof Johansson
  2007-11-15  1:12         ` Eric W. Biederman
  0 siblings, 1 reply; 6+ messages in thread
From: Olof Johansson @ 2007-11-15  0:28 UTC (permalink / raw)
  To: Randy Dunlap; +Cc: Eric W. Biederman, David Miller, akpm, netdev, linux-kernel

On Wed, Nov 14, 2007 at 08:45:28AM -0800, Randy Dunlap wrote:
> On Wed, 14 Nov 2007 08:56:20 -0700 Eric W. Biederman wrote:
> 
> > David Miller <davem@davemloft.net> writes:
> > 
> > > From: Olof Johansson <olof@lixom.net>
> > > Date: Tue, 13 Nov 2007 01:23:13 -0600
> > >
> > >> As seen when booting ppc64_defconfig:
> > >> 
> > >> sysctl table check failed: /net/token-ring .3.14 procname does not match
> > > binary path procname
> > >> 
> > >> 
> > >> Signed-off-by: Olof Johansson <olof@lixom.net>
> > >
> > > Patch applied, thanks Olof.
> > 
> > No objections but I think we already have this fixed in the -mm tree.
> 
> Yes, I patched it several weeks ago and it's been in -mm for a while
> now.  Apparently too long.

Ah, sorry for the duplicate patch then. I must have missed it at the
original posting (and didn't search that far back and/or -mm before
posting it myself).


-Olof

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] Fix warning for token-ring from sysctl checker
  2007-11-15  0:28       ` Olof Johansson
@ 2007-11-15  1:12         ` Eric W. Biederman
  0 siblings, 0 replies; 6+ messages in thread
From: Eric W. Biederman @ 2007-11-15  1:12 UTC (permalink / raw)
  To: Olof Johansson; +Cc: Randy Dunlap, David Miller, akpm, netdev, linux-kernel

Olof Johansson <olof@lixom.net> writes:

> On Wed, Nov 14, 2007 at 08:45:28AM -0800, Randy Dunlap wrote:
>> On Wed, 14 Nov 2007 08:56:20 -0700 Eric W. Biederman wrote:
>> 
>> > David Miller <davem@davemloft.net> writes:
>> > 
>> > > From: Olof Johansson <olof@lixom.net>
>> > > Date: Tue, 13 Nov 2007 01:23:13 -0600
>> > >
>> > >> As seen when booting ppc64_defconfig:
>> > >> 
>> > >> sysctl table check failed: /net/token-ring .3.14 procname does not match
>> > > binary path procname
>> > >> 
>> > >> 
>> > >> Signed-off-by: Olof Johansson <olof@lixom.net>
>> > >
>> > > Patch applied, thanks Olof.
>> > 
>> > No objections but I think we already have this fixed in the -mm tree.
>> 
>> Yes, I patched it several weeks ago and it's been in -mm for a while
>> now.  Apparently too long.
>
> Ah, sorry for the duplicate patch then. I must have missed it at the
> original posting (and didn't search that far back and/or -mm before
> posting it myself).

As long as the patch gets merged and makes it's way upstream so people
can use the token-ring code I don't really care who posts it.

Eric

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2007-11-15  1:13 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-11-13  7:23 [PATCH] Fix warning for token-ring from sysctl checker Olof Johansson
2007-11-14  5:15 ` David Miller
2007-11-14 15:56   ` Eric W. Biederman
2007-11-14 16:45     ` Randy Dunlap
2007-11-15  0:28       ` Olof Johansson
2007-11-15  1:12         ` Eric W. Biederman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).