LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] drivers/video/s1d13xxxfb.c as module with dbg
@ 2007-11-10 15:51 Stanislav Brabec
  2007-11-10 23:29 ` dave chung
  0 siblings, 1 reply; 4+ messages in thread
From: Stanislav Brabec @ 2007-11-10 15:51 UTC (permalink / raw)
  To: linux-kernel; +Cc: Thibaut VARENE

Attached patch fixes two compilation problems of s1d13xxxfb.c:
- Fixes outdated dbg() message to fix compilation error with debugging enabled.
- Do not read kernel command line options when compiled as module.

Signed-off-by: Stanislav Brabec <utx@penguin.cz>

--- linux-2.6.23/drivers/video/s1d13xxxfb.c	2007-10-09 22:31:38.000000000 +0200
+++ linux-2.6.23/drivers/video/s1d13xxxfb.c	2007-11-02 16:48:34.000000000 +0100
@@ -540,7 +540,7 @@
 	int ret = 0;
 	u8 revision;
 
-	dbg("probe called: device is %p\n", dev);
+	dbg("probe called: device is %p\n", pdev);
 
 	printk(KERN_INFO "Epson S1D13XXX FB Driver\n");
 
@@ -753,8 +753,11 @@
 static int __init
 s1d13xxxfb_init(void)
 {
+
+#ifndef MODULE
 	if (fb_get_options("s1d13xxxfb", NULL))
 		return -ENODEV;
+#endif
 
 	return platform_driver_register(&s1d13xxxfb_driver);
 }


________________________________________________________________________
Stanislav Brabec
http://www.penguin.cz/~utx


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] drivers/video/s1d13xxxfb.c as module with dbg
  2007-11-10 15:51 [PATCH] drivers/video/s1d13xxxfb.c as module with dbg Stanislav Brabec
@ 2007-11-10 23:29 ` dave chung
  2007-11-11 15:17   ` Thibaut VARENE
  2007-11-13 23:21   ` Kristoffer Ericson
  0 siblings, 2 replies; 4+ messages in thread
From: dave chung @ 2007-11-10 23:29 UTC (permalink / raw)
  To: Stanislav Brabec; +Cc: linux-kernel, Thibaut VARENE

On 11/10/07, Stanislav Brabec <utx@penguin.cz> wrote:
> Attached patch fixes two compilation problems of s1d13xxxfb.c:
> - Fixes outdated dbg() message to fix compilation error with debugging enabled.
> - Do not read kernel command line options when compiled as module.
>
> Signed-off-by: Stanislav Brabec <utx@penguin.cz>
>
> --- linux-2.6.23/drivers/video/s1d13xxxfb.c     2007-10-09 22:31:38.000000000 +0200
> +++ linux-2.6.23/drivers/video/s1d13xxxfb.c     2007-11-02 16:48:34.000000000 +0100
> @@ -540,7 +540,7 @@
>         int ret = 0;
>         u8 revision;
>
> -       dbg("probe called: device is %p\n", dev);
> +       dbg("probe called: device is %p\n", pdev);
>
>         printk(KERN_INFO "Epson S1D13XXX FB Driver\n");
>
> @@ -753,8 +753,11 @@
>  static int __init
>  s1d13xxxfb_init(void)
>  {
> +
> +#ifndef MODULE
>         if (fb_get_options("s1d13xxxfb", NULL))
>                 return -ENODEV;
> +#endif
>
>         return platform_driver_register(&s1d13xxxfb_driver);
>  }
>
>
>________________________________________________________________________
> Stanislav Brabec
> http://www.penguin.cz/~utx
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>

we also need to look at splitting out the "chip revision", which is
currently hard set, as I have had very good results with this driver
and  chip  S1D13506, which is functionally similar but without the
external clocking and without teh internal ram.
 We also have some build dependancies related to  "CONFIG_FB_S1D13XXX"
and  ics1523 , this chip is not used on the full range of S1D13XXX and
causes errors in the build , for chips such as S1D13506.
potentially we could re-use most of the code, but would need a way to
pass in S1D_CHIP_REV and one or 2 other chip specific data items.

Steve

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] drivers/video/s1d13xxxfb.c as module with dbg
  2007-11-10 23:29 ` dave chung
@ 2007-11-11 15:17   ` Thibaut VARENE
  2007-11-13 23:21   ` Kristoffer Ericson
  1 sibling, 0 replies; 4+ messages in thread
From: Thibaut VARENE @ 2007-11-11 15:17 UTC (permalink / raw)
  To: dave chung; +Cc: Stanislav Brabec, linux-kernel

On Nov 11, 2007 12:29 AM, dave chung <ponstrip@gmail.com> wrote:

> we also need to look at splitting out the "chip revision", which is
> currently hard set, as I have had very good results with this driver
> and  chip  S1D13506, which is functionally similar but without the
> external clocking and without teh internal ram.

Well I wrote the initial driver mostly as a rather quick hack. I
didn't have access to other hw from the s1d13 family (other than the
806) at that time, and could only guess that supporting them shouldn't
be too complicated. Nowadays I don't even have access to the 806
itself anymore, so I'm afraid I won't be of much help.

HTH

T-Bone

-- 
Thibaut VARENE
http://www.parisc-linux.org/~varenet/

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] drivers/video/s1d13xxxfb.c as module with dbg
  2007-11-10 23:29 ` dave chung
  2007-11-11 15:17   ` Thibaut VARENE
@ 2007-11-13 23:21   ` Kristoffer Ericson
  1 sibling, 0 replies; 4+ messages in thread
From: Kristoffer Ericson @ 2007-11-13 23:21 UTC (permalink / raw)
  To: dave chung; +Cc: Stanislav Brabec, linux-kernel, Thibaut VARENE

On Sun, 11 Nov 2007 07:29:35 +0800
"dave chung" <ponstrip@gmail.com> wrote:

> On 11/10/07, Stanislav Brabec <utx@penguin.cz> wrote:
> > Attached patch fixes two compilation problems of s1d13xxxfb.c:
> > - Fixes outdated dbg() message to fix compilation error with debugging enabled.
> > - Do not read kernel command line options when compiled as module.
> >
> > Signed-off-by: Stanislav Brabec <utx@penguin.cz>
> >
> > --- linux-2.6.23/drivers/video/s1d13xxxfb.c     2007-10-09 22:31:38.000000000 +0200
> > +++ linux-2.6.23/drivers/video/s1d13xxxfb.c     2007-11-02 16:48:34.000000000 +0100
> > @@ -540,7 +540,7 @@
> >         int ret = 0;
> >         u8 revision;
> >
> > -       dbg("probe called: device is %p\n", dev);
> > +       dbg("probe called: device is %p\n", pdev);
> >
> >         printk(KERN_INFO "Epson S1D13XXX FB Driver\n");
> >
> > @@ -753,8 +753,11 @@
> >  static int __init
> >  s1d13xxxfb_init(void)
> >  {
> > +
> > +#ifndef MODULE
> >         if (fb_get_options("s1d13xxxfb", NULL))
> >                 return -ENODEV;
> > +#endif
> >
> >         return platform_driver_register(&s1d13xxxfb_driver);
> >  }
> >
> >
> >________________________________________________________________________
> > Stanislav Brabec
> > http://www.penguin.cz/~utx
> >
> > -
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at  http://www.tux.org/lkml/
> >
> 
> we also need to look at splitting out the "chip revision", which is
> currently hard set, as I have had very good results with this driver
> and  chip  S1D13506, which is functionally similar but without the
> external clocking and without teh internal ram.
>  We also have some build dependancies related to  "CONFIG_FB_S1D13XXX"
> and  ics1523 , this chip is not used on the full range of S1D13XXX and
> causes errors in the build , for chips such as S1D13506.
> potentially we could re-use most of the code, but would need a way to
> pass in S1D_CHIP_REV and one or 2 other chip specific data items.

Im all for that. Got 2 platforms (Mobilepro 900c & HP Jornada 720) with both uses S1D13... based chipsets. The driver should
make more room for similiar versions.

> 
> Steve
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2007-11-13 23:16 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-11-10 15:51 [PATCH] drivers/video/s1d13xxxfb.c as module with dbg Stanislav Brabec
2007-11-10 23:29 ` dave chung
2007-11-11 15:17   ` Thibaut VARENE
2007-11-13 23:21   ` Kristoffer Ericson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).