LKML Archive on
help / color / mirror / Atom feed
From: Rusty Russell <>
To: Tejun Heo <>
Cc: Jeff Garzik <>,
Subject: Re: [PATCH] ata_sg_setup_one vs ata_sg_setup?
Date: Thu, 15 Nov 2007 23:36:34 +1100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Thursday 15 November 2007 15:08:00 Tejun Heo wrote:
> Rusty Russell wrote:
> > Hi Jeff,
> >
> >     Was looking through libata, and it seems to me that ata_sg_setup is a
> > superset of ata_sg_setup_one.  Am I missing something?  Seems like it
> > could be simplified.
> >
> > My machine never seems to do an ata_sg_setup_one, so this patch isn't
> > really tested...
> I have about the same patch queued here which also kills
> ata_sg_init_one() completely and replaces
> flag).  I'll compare your version and mine and see if mine is missing
> something.
> Thanks.

Great, thanks for the feedback.  I'd guess mine is more likely missing 
something than yours though...


      reply	other threads:[~2007-11-15 12:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-14  4:40 Rusty Russell
2007-11-14 12:25 ` Boaz Harrosh
2007-11-15  4:08 ` Tejun Heo
2007-11-15 12:36   ` Rusty Russell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \
    --subject='Re: [PATCH] ata_sg_setup_one vs ata_sg_setup?' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).