LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Jonas Stare <jonas.stare@purplescout.se>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
	Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linux-ide@vger.kernel.org
Subject: Re: [PATCH][RESUBMIT] drivers/ide/ide-probe.c, kernel 2.6.23.1
Date: Fri, 16 Nov 2007 22:22:54 +0100	[thread overview]
Message-ID: <200711162222.54847.bzolnier@gmail.com> (raw)
In-Reply-To: <473D88A5.306@purplescout.se>

On Friday 16 November 2007, Jonas Stare wrote:
> Resubmit of IDE-probing-patch. It now checks hwif->drives[unit].present instead of
> forced_geom and there is also an if-statement so it doesn't change back to the master
> unless it have to. I choose to put it inside the if-statement that checks the return
> code from ide_wait_not_busy, since it shouldn't revert back to the master drive unless
> something is wrong and we have to leave the function. (I also left the old SELECT_DRIVE
> after the for-loop so that we will select the master if everything is ok.) Inside the
> if-statement or not makes not big difference until you get more than two drives on the
> ide-bus...but this code should be ready for it. :)
> 
> Signed-off-by: Jonas Stare <jonas.stare@purplescout.se>

Patch looks fine (thanks for fixing it) but please replace the changelog
above with the proper patch description (more like in your first mail which
contained the description of the problem encountered and of the solution,
also please try to keep it within 80-columns limit) - for git history patch
changelog is not really that interesting/valuable.

PS patch summary ("Subject:") may also be improved while at it - it should
describe the main goal of the patch, also since patch will be applied to
the current git tree giving the kernel version is not necessary.

Bart

  parent reply	other threads:[~2007-11-16 21:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-09 10:22 [PATCH] " Jonas Stare
2007-11-12 21:24 ` Andrew Morton
2007-11-13  2:29   ` Alan Cox
2007-11-13 22:03   ` Bartlomiej Zolnierkiewicz
2007-11-15  8:52     ` Jonas Stare
2007-11-15 20:59       ` Bartlomiej Zolnierkiewicz
2007-11-16 12:10         ` [PATCH][RESUBMIT] " Jonas Stare
2007-11-16 12:51           ` Sergei Shtylyov
2007-11-16 17:46             ` Jonas Stare
2007-11-16 21:22           ` Bartlomiej Zolnierkiewicz [this message]
2007-11-16 22:57             ` [PATCH] drivers/ide/ide-probe.c Skip ide_wait_not_busy on noprobe-disks. was: " Jonas Stare
2007-11-18 21:39               ` Bartlomiej Zolnierkiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200711162222.54847.bzolnier@gmail.com \
    --to=bzolnier@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=benh@kernel.crashing.org \
    --cc=jonas.stare@purplescout.se \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: [PATCH][RESUBMIT] drivers/ide/ide-probe.c, kernel 2.6.23.1' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).