LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Pierre Ossman <drzeus@drzeus.cx>
To: Vitaly Luban <vitaly@luban.org>
Cc: linux-kernel@vger.kernel.org, Vitaly Luban <vitaly@luban.org>
Subject: Re: [PATCH] Tokyo Electron SDIO controller (Ellen) support
Date: Sat, 1 Dec 2007 21:50:10 +0100	[thread overview]
Message-ID: <20071201215010.2fa3b334@poseidon.drzeus.cx> (raw)
In-Reply-To: <47511ADA.20506@luban.org>

[-- Attachment #1: Type: text/plain, Size: 845 bytes --]

On Sat, 01 Dec 2007 00:27:06 -0800
Vitaly Luban <vitaly@luban.org> wrote:

> Kernel "pci_ids.h" file has data for that card missing.
> 
> Also, Ellen needs some control bits flipped before it functions properly 
> as SDIO controller by the spec.
> Should apply clenly to Linus and Drzeus trees. Please apply.
> 
> Signed-off-by:  Vitaly Luban <vitaly@luban.org>
> 
> 

The illiteracy rates for hardware engineers must be through the roof. Nobody seems capable of reading specifications anymore...

As for the patch, it's a big NAK at this point. Vendors who can't be bothered to follow the standard will have to wait for Ben's separation patches before they can be supported. Then they can have some voodoo front-end to handle their mistakes instead of turning sdhci.c into a collection of hacks and workarounds.

Rgds
Pierre

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

  reply	other threads:[~2007-12-01 20:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-01  8:27 Vitaly Luban
2007-12-01 20:50 ` Pierre Ossman [this message]
2007-12-03 14:22   ` Matt Porter
2007-12-03 14:39     ` Ben Dooks
2008-02-08 23:06       ` Pierre Ossman
2008-08-06 22:39 ` Pierre Ossman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071201215010.2fa3b334@poseidon.drzeus.cx \
    --to=drzeus@drzeus.cx \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vitaly@luban.org \
    --subject='Re: [PATCH] Tokyo Electron SDIO controller (Ellen) support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).