LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Carlos Corbacho <carlos@strangeworlds.co.uk>
To: oakad@exemail.com.au
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	drzeus@drzeus.cx, Alex Dubov <oakad@yahoo.com>
Subject: Re: [PATCH] [MEMSTICK] Initial commit for Sony MemoryStick support
Date: Mon, 31 Dec 2007 00:01:14 +0000	[thread overview]
Message-ID: <200712310001.15395.carlos@strangeworlds.co.uk> (raw)
In-Reply-To: <1198465597-14059-1-git-send-email-oakad@exemail.com.au>

Mostly just stylistic comments from me here.

On Monday 24 December 2007 03:06:37 oakad@exemail.com.au wrote:
> From: Alex Dubov <oakad@yahoo.com>
>
> Sony MemoryStick cards are used in many products manufactured by Sony. They
> are available both as storage and as IO expansion cards. Currently, only
> MemoryStick Pro storage cards are supported via TI FlashMedia MemoryStick
> interface.
>
> Signed-off-by: Alex Dubov <oakad@yahoo.com>

For MemoryStick Pro on my TI7421 card reader (since my old MemoryStick card 
and camera have disappeared somewhere, so I cannot currently test that):

Tested-by: Carlos Corbacho <carlos@strangeworlds.co.uk>

However, my only concerns are that:

1) tifm_ms was not autoloaded
2) On loading tifm_ms, only memstick was autoloaded - mspro_block was not.

Although, whether this is an issue with userspace (ie. udev) not dealing with 
the modules properly, I don't know.

> --- /dev/null
> +++ b/drivers/memstick/core/memstick.c
> @@ -0,0 +1,557 @@
> +/*
> + *  memstick.c - Sony MemoryStick support

File names in comments are now frowned upon - there was a thread on this in 
October on LKML:

http://lkml.org/lkml/2007/10/12/524

Also, before Andrew gets in with this - you should run this through 
checkpatch, as there are a few errors it throws up (mostly foo* and C99 
comments).

-Carlos
-- 
E-Mail: carlos@strangeworlds.co.uk
Web: strangeworlds.co.uk
GPG Key ID: 0x23EE722D

  reply	other threads:[~2007-12-31  0:01 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-24  3:06 oakad
2007-12-31  0:01 ` Carlos Corbacho [this message]
2007-12-31  0:31   ` Jan Engelhardt
2007-12-31  0:54     ` Alex Dubov
2007-12-31  0:56     ` Carlos Corbacho
2007-12-31  1:01   ` Alex Dubov
2007-12-31  1:15     ` Carlos Corbacho
2007-12-31  4:51       ` Alex Dubov
2008-01-02  6:42 oakad
2008-01-10  9:00 ` Andrew Morton
2008-01-11 12:14   ` Jens Axboe
2008-01-14  3:26   ` Alex Dubov
2008-01-22 16:12   ` Alex Dubov
2008-01-22 18:59     ` Andrew Morton
2008-01-15 17:21 ` Mariusz Kozlowski
2008-01-16  1:52   ` Alex Dubov
2008-01-13 22:47 Miguel Botón

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200712310001.15395.carlos@strangeworlds.co.uk \
    --to=carlos@strangeworlds.co.uk \
    --cc=akpm@linux-foundation.org \
    --cc=drzeus@drzeus.cx \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oakad@exemail.com.au \
    --cc=oakad@yahoo.com \
    --subject='Re: [PATCH] [MEMSTICK] Initial commit for Sony MemoryStick support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).