LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: Greg Kroah-Hartman <gregkh@suse.de>
Cc: linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	torvalds@linux-foundation.org, stable@kernel.org,
	Zhao Yakui <yakui.zhao@intel.com>,
	Li Shaohua <shaohua.li@intel.com>,
	Thomas Renninger <trenn@suse.de>, Adam Belay <ambx1@neo.rr.com>,
	Len Brown <lenb@kernel.org>
Subject: Re: Linux 2.6.23.12
Date: Wed, 2 Jan 2008 13:42:23 -0700	[thread overview]
Message-ID: <200801021342.23763.bjorn.helgaas@hp.com> (raw)
In-Reply-To: <20071218224635.GB12696@kroah.com>

The patch below was put in 2.6.23.12 as a fix for
http://bugzilla.kernel.org/show_bug.cgi?id=9514.  It apparently
does make 9514 go away, but only by coincidence.  There are a
couple other ideas about fixing 9514.  My proposed patch is
attached in the bugzilla.

The .12 patch reduces the number of resources we reserve from
24 to 8 ioport regions and from 12 to 4 mmio regions per PNP device.
It also removes a warning about regions we ignore.

Obviously, we want to reserve ALL the regions for PNP devices,
and Thomas is working on a patch for that (which I hope will be
ready for 2.6.25).  But in the meantime, the .12 patch makes it
more likely that we will have resource conflicts with PNP devices.

http://bugzilla.kernel.org/show_bug.cgi?id=9630 appears to be
such a conflict.

I think the patch below should be removed from the stable series.

Bjorn

On Tuesday 18 December 2007 03:46:36 pm Greg Kroah-Hartman wrote:
> diff --git a/Makefile b/Makefile
> index ada10d5..96c3f02 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1,7 +1,7 @@
>  VERSION = 2
>  PATCHLEVEL = 6
>  SUBLEVEL = 23
> -EXTRAVERSION = .11
> +EXTRAVERSION = .12
>  NAME = Arr Matey! A Hairy Bilge Rat!
>  
>  # *DOCUMENTATION*
> diff --git a/drivers/pnp/pnpacpi/rsparser.c b/drivers/pnp/pnpacpi/rsparser.c
> index 5abf5ea..0e3b8d0 100644
> --- a/drivers/pnp/pnpacpi/rsparser.c
> +++ b/drivers/pnp/pnpacpi/rsparser.c
> @@ -82,11 +82,9 @@ static void pnpacpi_parse_allocated_irqresource(struct pnp_resource_table *res,
>  	while (!(res->irq_resource[i].flags & IORESOURCE_UNSET) &&
>  	       i < PNP_MAX_IRQ)
>  		i++;
> -	if (i >= PNP_MAX_IRQ) {
> -		printk(KERN_ERR "pnpacpi: exceeded the max number of IRQ "
> -				"resources: %d \n", PNP_MAX_IRQ);
> +	if (i >= PNP_MAX_IRQ)
>  		return;
> -	}
> +
>  	res->irq_resource[i].flags = IORESOURCE_IRQ;	// Also clears _UNSET flag
>  	res->irq_resource[i].flags |= irq_flags(triggering, polarity);
>  	irq = acpi_register_gsi(gsi, triggering, polarity);
> @@ -165,9 +163,6 @@ static void pnpacpi_parse_allocated_dmaresource(struct pnp_resource_table *res,
>  		}
>  		res->dma_resource[i].start = dma;
>  		res->dma_resource[i].end = dma;
> -	} else {
> -		printk(KERN_ERR "pnpacpi: exceeded the max number of DMA "
> -				"resources: %d \n", PNP_MAX_DMA);
>  	}
>  }
>  
> @@ -189,9 +184,6 @@ static void pnpacpi_parse_allocated_ioresource(struct pnp_resource_table *res,
>  		}
>  		res->port_resource[i].start = io;
>  		res->port_resource[i].end = io + len - 1;
> -	} else {
> -		printk(KERN_ERR "pnpacpi: exceeded the max number of IO "
> -				"resources: %d \n", PNP_MAX_PORT);
>  	}
>  }
>  
> @@ -215,9 +207,6 @@ static void pnpacpi_parse_allocated_memresource(struct pnp_resource_table *res,
>  
>  		res->mem_resource[i].start = mem;
>  		res->mem_resource[i].end = mem + len - 1;
> -	} else {
> -		printk(KERN_ERR "pnpacpi: exceeded the max number of mem "
> -				"resources: %d\n", PNP_MAX_MEM);
>  	}
>  }
>  
> diff --git a/include/linux/pnp.h b/include/linux/pnp.h
> index 62decab..16b46aa 100644
> --- a/include/linux/pnp.h
> +++ b/include/linux/pnp.h
> @@ -13,8 +13,8 @@
>  #include <linux/errno.h>
>  #include <linux/mod_devicetable.h>
>  
> -#define PNP_MAX_PORT		24
> -#define PNP_MAX_MEM		12
> +#define PNP_MAX_PORT		8
> +#define PNP_MAX_MEM		4
>  #define PNP_MAX_IRQ		2
>  #define PNP_MAX_DMA		2
>  #define PNP_NAME_LEN		50

  reply	other threads:[~2008-01-02 20:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-18 22:45 Greg Kroah-Hartman
2007-12-18 22:46 ` Greg Kroah-Hartman
2008-01-02 20:42   ` Bjorn Helgaas [this message]
2008-01-03  1:16     ` Shaohua Li
2008-01-10  3:49     ` Greg KH
2008-01-10 16:06       ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200801021342.23763.bjorn.helgaas@hp.com \
    --to=bjorn.helgaas@hp.com \
    --cc=akpm@linux-foundation.org \
    --cc=ambx1@neo.rr.com \
    --cc=gregkh@suse.de \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shaohua.li@intel.com \
    --cc=stable@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=trenn@suse.de \
    --cc=yakui.zhao@intel.com \
    --subject='Re: Linux 2.6.23.12' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).