LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: David Brownell <david-b@pacbell.net>,
Dave Young <hidave.darkstar@gmail.com>,
stern@rowland.harvard.edu, peterz@infradead.org,
davem@davemloft.net, jarkao2@gmail.com, krh@redhat.com,
dbrownell@users.sourceforge.net,
James.Bottomley@hansenpartnership.com, a.zummo@towertech.it,
cbou@mail.ru, dwmw2@infradead.org,
linux1394-devel@lists.sourceforge.net,
spi-devel-general@lists.sourceforge.net,
linux-scsi@vger.kernel.org, rtc-linux@googlegroups.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/7] convert semaphore to mutex in struct class
Date: Mon, 7 Jan 2008 07:44:04 -0800 [thread overview]
Message-ID: <20080107154404.GA10880@suse.de> (raw)
In-Reply-To: <478227D5.8050402@s5r6.in-berlin.de>
On Mon, Jan 07, 2008 at 02:23:33PM +0100, Stefan Richter wrote:
> David Brownell wrote:
> > On Monday 07 January 2008, Greg KH wrote:
> >> Most of the non-driver core code should be converted to not use the
> >> lock in the class at all. They should use a local lock instead.
> >
> > Or better yet, that yet-to-be-written class_for_each_instance()
> > iterator ... :)
>
> By far most of the usages of class.semaphore or class.mutex in drivers
> are to protect the class.devices list. The only? right thing to do
> there is to keep using the class.{semaphore,mutex}. The more elegant
> variation of this would be David's class_for_each_instance() iterator
> which would allow us to hide the locking details from the drivers.
If such functionality is needed, fine, I have no objection to that
change to move the locking logic into the driver core.
thanks,
greg k-h
next prev parent reply other threads:[~2008-01-07 16:36 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-03 5:50 Dave Young
2008-01-03 7:06 ` Jarek Poplawski
2008-01-03 7:24 ` Jarek Poplawski
2008-01-03 7:21 ` Dave Young
2008-01-03 7:41 ` Jarek Poplawski
2008-01-06 18:41 ` Stefan Richter
2008-01-07 2:09 ` Dave Young
2008-01-07 8:45 ` Greg KH
2008-01-07 9:01 ` David Brownell
2008-01-07 13:23 ` Stefan Richter
2008-01-07 14:00 ` Jarek Poplawski
2008-01-07 16:36 ` Stefan Richter
2008-01-07 15:44 ` Greg KH [this message]
2008-01-07 17:13 ` Stefan Richter
2008-01-07 17:20 ` Greg KH
2008-01-08 7:05 ` Dave Young
2008-01-08 22:48 ` Greg KH
2008-01-09 1:32 ` Dave Young
2008-01-09 6:13 ` Dave Young
2008-01-09 6:37 ` Dave Young
2008-01-09 6:39 ` Dave Young
2008-01-10 9:48 ` Dave Young
2008-01-10 12:34 ` Stefan Richter
2008-01-11 2:18 ` Dave Young
2008-01-10 13:23 ` Cornelia Huck
2008-01-11 2:33 ` Dave Young
2008-01-11 8:23 ` Cornelia Huck
2008-01-11 8:53 ` Dave Young
2008-01-10 15:41 ` Alan Stern
2008-01-11 2:37 ` Dave Young
2008-01-10 18:39 ` Greg KH
2008-01-11 2:40 ` Dave Young
2008-01-07 17:25 ` Alan Stern
2008-01-07 10:00 ` Dave Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080107154404.GA10880@suse.de \
--to=gregkh@suse.de \
--cc=James.Bottomley@hansenpartnership.com \
--cc=a.zummo@towertech.it \
--cc=cbou@mail.ru \
--cc=davem@davemloft.net \
--cc=david-b@pacbell.net \
--cc=dbrownell@users.sourceforge.net \
--cc=dwmw2@infradead.org \
--cc=hidave.darkstar@gmail.com \
--cc=jarkao2@gmail.com \
--cc=krh@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=peterz@infradead.org \
--cc=rtc-linux@googlegroups.com \
--cc=spi-devel-general@lists.sourceforge.net \
--cc=stefanr@s5r6.in-berlin.de \
--cc=stern@rowland.harvard.edu \
--subject='Re: [PATCH 0/7] convert semaphore to mutex in struct class' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).