LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Takashi Iwai <tiwai@suse.de>
Cc: Harald Dunkel <harald.dunkel@t-online.de>,
	linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: 2.6.24-rc7, intel audio: alsa doesn't say a beep
Date: Tue, 8 Jan 2008 11:10:24 +0100	[thread overview]
Message-ID: <20080108101024.GB6906@elte.hu> (raw)
In-Reply-To: <s5h3at8rd9c.wl%tiwai@suse.de>


* Takashi Iwai <tiwai@suse.de> wrote:

> > The only difference between rc6 and rc7 in sound/pci/hda/hda_intel.c is
> > this:
> > 
> > diff -ur linux-2.6.24-rc6/sound/pci/hda/hda_intel.c linux-2.6.24-rc7/sound/pci/hda/hda_intel.c
> > --- linux-2.6.24-rc6/sound/pci/hda/hda_intel.c	2007-12-21 02:25:48.000000000 +0100
> > +++ linux-2.6.24-rc7/sound/pci/hda/hda_intel.c	2008-01-06 22:45:38.000000000 +0100
> > @@ -555,7 +555,8 @@
> >   		}
> >   		if (!chip->rirb.cmds)
> >   			return chip->rirb.res; /* the last value */
> > -		schedule_timeout_uninterruptible(1);
> > +		udelay(10);
> > +		cond_resched();
> >   	} while (time_after_eq(timeout, jiffies));
> > 
> >   	if (chip->msi) {
> > 
> > 
> > Do you think this could be related to the problem?
> 
> Could you revert it and check whether the problem still exists?
> 
> I hardly believe it's the culprit, but if this is the only change in
> the sound subsystem...

lets revert it (commit 57a04513cb3) if it's causing problems. This patch 
sat in -mm for quite some time - so it seems -rc7 is getting pretty good 
test coverage.

	Ingo

  reply	other threads:[~2008-01-08 10:10 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-07 19:53 Harald Dunkel
2008-01-08  7:24 ` Takashi Iwai
2008-01-08 10:10   ` Ingo Molnar [this message]
2008-01-08 17:01   ` Harald Dunkel
2008-01-08 17:43     ` Takashi Iwai
2008-01-09  6:03       ` Harald Dunkel
2008-01-09  7:31         ` Takashi Iwai
2008-01-09 20:10           ` Harald Dunkel
2008-01-10 13:30             ` Takashi Iwai
2008-01-10 22:02               ` Harald Dunkel
2008-01-11  6:49                 ` Takashi Iwai
2008-01-11 21:55                   ` Harald Dunkel
2008-01-13 11:17                     ` Takashi Iwai
2008-01-14 20:46                       ` Harald Dunkel
2008-01-15 10:07                         ` Takashi Iwai
2008-01-12  9:41                   ` Harald Dunkel
2008-01-12 17:11                     ` Daniel Hazelton
2008-01-14 11:04                       ` Takashi Iwai
2008-01-14 21:03                         ` Daniel Hazelton
2008-01-15 10:08                           ` Takashi Iwai
2008-01-15 19:00                             ` Daniel Hazelton
2008-01-13 11:26                     ` Takashi Iwai
2008-01-16  6:53       ` Harald Dunkel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080108101024.GB6906@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@linux-foundation.org \
    --cc=harald.dunkel@t-online.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tiwai@suse.de \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: 2.6.24-rc7, intel audio: alsa doesn'\''t say a beep' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).