LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* Build Fails on 2.6.24-rc6-mm1[drivers/net/iseries_veth.ko] linking error
@ 2008-01-09 10:14 Sudhir Kumar
  2008-01-09 19:14 ` Sam Ravnborg
  0 siblings, 1 reply; 3+ messages in thread
From: Sudhir Kumar @ 2008-01-09 10:14 UTC (permalink / raw)
  To: akpm; +Cc: linux-kernel, sam

Hi Andrew,
Build fails on my Power Machine with following error message.


 HOSTLD  arch/powerpc/boot/dtc
 WRAP    arch/powerpc/boot/zImage.pseries
 WRAP    arch/powerpc/boot/zImage.pmac
strip -s -R .comment vmlinux -o arch/powerpc/boot/zImage.iseries
 Building modules, stage 2.
 MODPOST 264 modules
ERROR: ".driver_add_kobj" [drivers/net/iseries_veth.ko] undefined!
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2

Thanks and Regards,
Sudhir Kumar

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Build Fails on 2.6.24-rc6-mm1[drivers/net/iseries_veth.ko] linking error
  2008-01-09 10:14 Build Fails on 2.6.24-rc6-mm1[drivers/net/iseries_veth.ko] linking error Sudhir Kumar
@ 2008-01-09 19:14 ` Sam Ravnborg
  2008-01-09 19:39   ` Greg KH
  0 siblings, 1 reply; 3+ messages in thread
From: Sam Ravnborg @ 2008-01-09 19:14 UTC (permalink / raw)
  To: Sudhir Kumar; +Cc: akpm, linux-kernel, Greg Kroah-Hartman

On Wed, Jan 09, 2008 at 03:44:04PM +0530, Sudhir Kumar wrote:
> Hi Andrew,
> Build fails on my Power Machine with following error message.
> 
> 
>  HOSTLD  arch/powerpc/boot/dtc
>  WRAP    arch/powerpc/boot/zImage.pseries
>  WRAP    arch/powerpc/boot/zImage.pmac
> strip -s -R .comment vmlinux -o arch/powerpc/boot/zImage.iseries
>  Building modules, stage 2.
>  MODPOST 264 modules
> ERROR: ".driver_add_kobj" [drivers/net/iseries_veth.ko] undefined!
> make[1]: *** [__modpost] Error 1
> make: *** [modules] Error 2

driver_add_kobj has a single user - iseries_veth. It is even documented
in the comment in the file.
And you build iseries_veth as a module but driver_add_kobj is not exported
which is why you get this modpost error.

Workaround: make the driver built-in
Fix: export driver_add_kobj or replace usage in iseries_veth.

	Sam

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Build Fails on 2.6.24-rc6-mm1[drivers/net/iseries_veth.ko] linking error
  2008-01-09 19:14 ` Sam Ravnborg
@ 2008-01-09 19:39   ` Greg KH
  0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2008-01-09 19:39 UTC (permalink / raw)
  To: Sam Ravnborg; +Cc: Sudhir Kumar, akpm, linux-kernel

On Wed, Jan 09, 2008 at 08:14:56PM +0100, Sam Ravnborg wrote:
> On Wed, Jan 09, 2008 at 03:44:04PM +0530, Sudhir Kumar wrote:
> > Hi Andrew,
> > Build fails on my Power Machine with following error message.
> > 
> > 
> >  HOSTLD  arch/powerpc/boot/dtc
> >  WRAP    arch/powerpc/boot/zImage.pseries
> >  WRAP    arch/powerpc/boot/zImage.pmac
> > strip -s -R .comment vmlinux -o arch/powerpc/boot/zImage.iseries
> >  Building modules, stage 2.
> >  MODPOST 264 modules
> > ERROR: ".driver_add_kobj" [drivers/net/iseries_veth.ko] undefined!
> > make[1]: *** [__modpost] Error 1
> > make: *** [modules] Error 2
> 
> driver_add_kobj has a single user - iseries_veth. It is even documented
> in the comment in the file.
> And you build iseries_veth as a module but driver_add_kobj is not exported
> which is why you get this modpost error.
> 
> Workaround: make the driver built-in
> Fix: export driver_add_kobj or replace usage in iseries_veth.

I'll properly export this symbol, that's the right fix.

Sorry about this,

greg k-h

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-01-09 21:15 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-01-09 10:14 Build Fails on 2.6.24-rc6-mm1[drivers/net/iseries_veth.ko] linking error Sudhir Kumar
2008-01-09 19:14 ` Sam Ravnborg
2008-01-09 19:39   ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).