LKML Archive on
help / color / mirror / Atom feed
From: Andrew Morton <>
To: Pierre Peiffer <>
Subject: Re: [-mm] new warning in ipc/msg.c
Date: Wed, 9 Jan 2008 15:13:19 -0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Wed, 09 Jan 2008 16:42:34 +0100
Pierre Peiffer <> wrote:

> Hi,
> This very small patch:
>     ipc-convert-handmade-min-to-min.patch
> introduces a new warning when compiling the -mm kernel:
> .../linux-2.6.24-rc6-mm1/ipc/msg.c: In function `do_msgrcv':
> .../linux-2.6.24-rc6-mm1/ipc/msg.c:939: warning: comparison of distinct pointer
> types lacks a cast
> I don't know if doing in include/linux/msg.h
> struct msg_msg {
> 	struct list_head m_list;
> 	long  m_type;
> -	int m_ts;           /* message text size */
> +	size_t m_ts;           /* message text size */
> 	struct msg_msgseg* next;
> 	void *security;
> 	/* the actual message follows immediately */
> };
> is acceptable ?
> Otherwise, either a cast can be added or this patch can be dropped...

Thanks.  I think I'll drop the original patch.  The mix of ints, size_t's,
etc in that code is pretty random and would be best addressed by somene
sitting down and working out from scratch what types we _should_ be using
in there and then making all the code use the right types in an organised

Doing this in a piecemeal through-a-pinhole fashion won't work very well
and is a bit risky.

  reply	other threads:[~2008-01-09 23:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-09 15:42 Pierre Peiffer
2008-01-09 23:13 ` Andrew Morton [this message]
2008-01-10  8:30   ` Pierre Peiffer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \
    --subject='Re: [-mm] new warning in ipc/msg.c' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).