LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Andi Kleen <andi@firstfloor.org>
Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: More breakage in native_rdtsc out of line in git-x86
Date: Wed, 9 Jan 2008 16:22:08 +0100	[thread overview]
Message-ID: <20080109152208.GA21280@elte.hu> (raw)
In-Reply-To: <20080109141908.GB12855@one.firstfloor.org>


* Andi Kleen <andi@firstfloor.org> wrote:

> > nope, it's a 64-bit setup/dependency bug/problem: the vsyscall mappings 
> > are installed via an __initcall, and that's too late for early use. The 
> > combo patch below fixed the crash for me, does it work on your box too?
> 
> That gives
> 
> /home/lsrc/quilt/linux/arch/x86/kernel/setup_64.c: In function 'setup_arch':
> /home/lsrc/quilt/linux/arch/x86/kernel/setup_64.c:468: error: implicit declarati
> on of function 'map_vsyscall'

i guess you have an old repository.

> But after I add a prototype to vsyscall.h it seems to work.
> 
> Just the barriers are still broken [...]

since yesterday there's a full barrier around rdtsc.

	Ingo

  reply	other threads:[~2008-01-09 15:22 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-09  3:55 More breakage in native_rdtsc out of line in git-x86 Andi Kleen
2008-01-09  5:21 ` More breakage in native_rdtsc out of line in git-x86 II Andi Kleen
2008-01-09  9:09 ` More breakage in native_rdtsc out of line in git-x86 Ingo Molnar
2008-01-09 14:19   ` Andi Kleen
2008-01-09 15:22     ` Ingo Molnar [this message]
2008-01-09 15:51       ` Andi Kleen
2008-01-09 16:30         ` Ingo Molnar
2008-01-09 17:48           ` Andi Kleen
2008-01-09 20:25             ` Arjan van de Ven
2008-01-09 20:40               ` Andi Kleen
2008-01-09 20:57                 ` H. Peter Anvin
2008-01-09 22:09             ` Björn Steinbrink
2008-01-09 22:28               ` Andi Kleen
2008-01-09 22:35                 ` Harvey Harrison
2008-01-09 22:41                   ` Andi Kleen
2008-01-09 23:21                     ` Björn Steinbrink
2008-01-09 23:37                     ` Paolo Ciarrocchi
2008-01-11  5:21                       ` Cyrill Gorcunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080109152208.GA21280@elte.hu \
    --to=mingo@elte.hu \
    --cc=andi@firstfloor.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).