LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Andi Kleen <andi@firstfloor.org>,
	Christoph Hellwig <hch@infradead.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Pavel Roskin <proski@gnu.org>, Dave Airlie <airlied@gmail.com>,
	Pekka Paalanen <pq@iki.fi>,
	linux-kernel@vger.kernel.org, jbeulich@novell.com
Subject: Re: Replacement for page fault notifiers?
Date: Thu, 10 Jan 2008 02:01:11 +0100	[thread overview]
Message-ID: <20080110010111.GF18480@one.firstfloor.org> (raw)
In-Reply-To: <20080109165515.4a6256a8@laptopd505.fenrus.org>

On Wed, Jan 09, 2008 at 04:55:15PM -0800, Arjan van de Ven wrote:
> On Thu, 10 Jan 2008 01:47:16 +0100
> Andi Kleen <andi@firstfloor.org> wrote:
> 
> > Arjan van de Ven <arjan@infradead.org> writes:
> > >
> > > I'm btw all in favor of making mmio tracing full fledged kernel
> > > infrastructure. This doesn't mean "notifier" imo; this means a real
> > > flag in the struct page, and then the page fault code can do
> > >
> > > if (page->flags & FLAG_MMIO_TRACED)
> > > 	mmio_trace(page, regs, whatever..);
> > >
> > > (probably surrounded by a CONFIG_ ifdef)
> > > THis is a TON lighter than a notifier chain, and actually what you
> > > want, you don't really want a notifier, you want a call back when a
> > > special kind of page is touched.
> > 
> > That would assume that your mmio area has a struct page. In most PCs 
> > the ones in the PCI hole don't
> > 
> 
> so you also call the function for all traps on pages without struct page;
> that should be extremely rare anyway, and the mmio_trace code can then 
> look the page up.

But there's really no page to look up. These are typically !pfn_valid()

You would need to create an own backing infrastructure. Perhaps you can reuse
some of that from the future PAT code, but integrating that into the page fault
will be probably ugly.

-Andi

  parent reply	other threads:[~2008-01-10  0:59 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-08 19:06 Pekka Paalanen
2008-01-08 20:32 ` Christoph Hellwig
2008-01-08 22:13   ` Dave Airlie
2008-01-09  0:26     ` Benjamin Herrenschmidt
2008-01-09 18:18       ` Pavel Roskin
2008-01-09 18:21         ` Christoph Hellwig
2008-01-09 19:58           ` Benjamin Herrenschmidt
2008-01-09 20:22             ` Christoph Hellwig
2008-01-10  0:42               ` Arjan van de Ven
2008-01-10  0:47                 ` Andi Kleen
2008-01-10  0:55                   ` Arjan van de Ven
2008-01-10  0:58                     ` Benjamin Herrenschmidt
2008-01-10  1:01                     ` Andi Kleen [this message]
2008-01-10  0:56                 ` Benjamin Herrenschmidt
2008-01-10  2:03                 ` Matt Mackall
2008-01-10  2:21                   ` Pavel Roskin
2008-01-10  2:30                     ` Matt Mackall
2008-01-10 18:44               ` Pekka Paalanen
2008-01-09 20:24             ` Pavel Roskin
2008-01-09 20:26               ` Christoph Hellwig
2008-01-09 20:41                 ` Pavel Roskin
2008-01-09 20:44                 ` Valdis.Kletnieks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080110010111.GF18480@one.firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=airlied@gmail.com \
    --cc=arjan@infradead.org \
    --cc=benh@kernel.crashing.org \
    --cc=hch@infradead.org \
    --cc=jbeulich@novell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pq@iki.fi \
    --cc=proski@gnu.org \
    --subject='Re: Replacement for page fault notifiers?' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).