LKML Archive on
help / color / mirror / Atom feed
From: Ingo Molnar <>
To: Harvey Harrison <>
Cc: "H. Peter Anvin" <>,
	LKML <>,
	Thomas Gleixner <>
Subject: Re: [PATCH] x86: Move get_segment_eip() to step.c
Date: Thu, 10 Jan 2008 13:44:21 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <1199950614.19760.16.camel@brick>

* Harvey Harrison <> wrote:

> get_segment_eip has similarities to convert_rip_to_linear(), and is 
> used in a similar context.  Move get_segment_eip to step.c to allow 
> easier consolidation.

thanks, applied.

> Ingo, you may want to fold this into my previous patch:
> x86: begin fault_{32|64}.c unification

i'd rather keep this gradual. Unless there's a lot of flip-flop this is 
more maintainable. "use this new version for patch X" is harder (more 
error-prone) to do for a maintainer than "please merge this new gradual 
patch". We can fold too if really needed: due to bisection/build/crash 


      reply	other threads:[~2008-01-10 12:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-10  7:36 Harvey Harrison
2008-01-10 12:44 ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \
    --subject='Re: [PATCH] x86: Move get_segment_eip() to step.c' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).