LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Dave Young <hidave.darkstar@gmail.com>
Cc: Stefan Richter <stefanr@s5r6.in-berlin.de>,
	James.Bottomley@hansenpartnership.com,
	linux-scsi@vger.kernel.org, a.zummo@towertech.it,
	peterz@infradead.org, cbou@mail.ru, linux-kernel@vger.kernel.org,
	David Brownell <david-b@pacbell.net>,
	krh@redhat.com, stern@rowland.harvard.edu,
	rtc-linux@googlegroups.com,
	spi-devel-general@lists.sourceforge.net,
	linux1394-devel@lists.sourceforge.net, dwmw2@infradead.org,
	davem@davemloft.net, jarkao2@gmail.com
Subject: Re: [PATCH 0/7] convert semaphore to mutex in struct class
Date: Thu, 10 Jan 2008 10:39:17 -0800	[thread overview]
Message-ID: <20080110183917.GA20188@suse.de> (raw)
In-Reply-To: <20080110094843.GA3014@darkstar.te-china.tietoenator.com>

On Thu, Jan 10, 2008 at 05:48:43PM +0800, Dave Young wrote:
> The patches are done on my side, please help to check. 

Along with all of the other comments from people, I have a few.

> This is the first one of the series about driver core changes. 
> If this one is accepted and there's no other problem I will post the others for maintainer's review (they need your comment and help because I don't know well about the specific driver logic).
> 
> Thanks a lot in advance.
> ---
> 
> 1. convert class semaphore to mutex.
> 2. add class iterater functions to encapsulate the detail of class devices/children list iterating :
> 	class_for_each_device
> 	class_find_device
> 	class_for_each_child
> 	class_find_child

No, please create 1 patch per type-of-change.

So in this case you would have a series of patches:
	1) add the class iterator functions
	2-n) convert the existing places in the kernel using the
	     class->semaphore to use the new iterator functions
	n+1) convert class semaphore to mutex, which should only touch
	     the driver core

That way everything builds along the way, and it's easy to understand
and review.

Oh, and please start a new thread when you create a new patch like this
so it doesn't get burried in people's inboxes...

thanks,

greg k-h

  parent reply	other threads:[~2008-01-10 18:39 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-03  5:50 Dave Young
2008-01-03  7:06 ` Jarek Poplawski
2008-01-03  7:24   ` Jarek Poplawski
2008-01-03  7:21     ` Dave Young
2008-01-03  7:41       ` Jarek Poplawski
2008-01-06 18:41 ` Stefan Richter
2008-01-07  2:09   ` Dave Young
2008-01-07  8:45     ` Greg KH
2008-01-07  9:01       ` David Brownell
2008-01-07 13:23         ` Stefan Richter
2008-01-07 14:00           ` Jarek Poplawski
2008-01-07 16:36             ` Stefan Richter
2008-01-07 15:44           ` Greg KH
2008-01-07 17:13             ` Stefan Richter
2008-01-07 17:20               ` Greg KH
2008-01-08  7:05                 ` Dave Young
2008-01-08 22:48                   ` Greg KH
2008-01-09  1:32                     ` Dave Young
2008-01-09  6:13                       ` Dave Young
2008-01-09  6:37                         ` Dave Young
2008-01-09  6:39                           ` Dave Young
2008-01-10  9:48                             ` Dave Young
2008-01-10 12:34                               ` Stefan Richter
2008-01-11  2:18                                 ` Dave Young
2008-01-10 13:23                               ` Cornelia Huck
2008-01-11  2:33                                 ` Dave Young
2008-01-11  8:23                                   ` Cornelia Huck
2008-01-11  8:53                                     ` Dave Young
2008-01-10 15:41                               ` Alan Stern
2008-01-11  2:37                                 ` Dave Young
2008-01-10 18:39                               ` Greg KH [this message]
2008-01-11  2:40                                 ` Dave Young
2008-01-07 17:25               ` Alan Stern
2008-01-07 10:00       ` Dave Young

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080110183917.GA20188@suse.de \
    --to=gregkh@suse.de \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=a.zummo@towertech.it \
    --cc=cbou@mail.ru \
    --cc=davem@davemloft.net \
    --cc=david-b@pacbell.net \
    --cc=dwmw2@infradead.org \
    --cc=hidave.darkstar@gmail.com \
    --cc=jarkao2@gmail.com \
    --cc=krh@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    --cc=peterz@infradead.org \
    --cc=rtc-linux@googlegroups.com \
    --cc=spi-devel-general@lists.sourceforge.net \
    --cc=stefanr@s5r6.in-berlin.de \
    --cc=stern@rowland.harvard.edu \
    --subject='Re: [PATCH 0/7] convert semaphore to mutex in struct class' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).