LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Jiri Kosina <jikos@jikos.cz>
Cc: Matthew Wilcox <matthew@wil.cx>,
	Nikanth Karthikesan <knikanth@suse.de>,
	grant@torque.net, tim@cyberelk.net, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Change paride driver to use unlocked_ioctl instead of ioctl
Date: Thu, 10 Jan 2008 20:58:26 +0000	[thread overview]
Message-ID: <20080110205826.7c41b247@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <Pine.LNX.4.64.0801101601000.25041@twin.jikos.cz>

On Thu, 10 Jan 2008 16:01:44 +0100 (CET)
Jiri Kosina <jikos@jikos.cz> wrote:

> On Wed, 9 Jan 2008, Alan Cox wrote:
> 
> > > > >  	default:
> > > > >  		printk("%s: Unimplemented ioctl 0x%x\n", tape->name, cmd);
> > > > > +		unlock_kernel();
> > > > >  		return -EINVAL;
> > > > Surely a bug ... shouldn't this return -ENOTTY?
> > Agreed - ENOTTY. 
> 
> Just out of curiosity, where does POSIX happen to specify ENOTTY as the 
> correct one for unimplemented ioctl?

I don't know if POSIX does, but Unix has always used ENOTTY for "I don't
know what this ioctl is" and -EINVAL "for I know what this ioctl is but
the values passed are stupid"

  reply	other threads:[~2008-01-10 21:01 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-10  6:14 Nikanth Karthikesan
2008-01-09  8:06 ` Christoph Hellwig
2008-01-09  8:23   ` Valdis.Kletnieks
     [not found]   ` <4784D3E0.BANGALORE.BLR.100.174746A.1.EABB.1@1:7.BANGALORE.BLR.100.0.1.0.1@16>
2008-01-10  8:55     ` Nikanth Karthikesan
2008-01-09 12:14       ` Jan Engelhardt
2008-01-09 12:20         ` Christoph Hellwig
2008-01-10  7:23 ` Nikanth Karthikesan
2008-01-09 12:33   ` Matthew Wilcox
2008-01-09 13:26     ` Jiri Kosina
2008-01-09 16:56       ` Alan Cox
2008-01-10 15:01         ` Jiri Kosina
2008-01-10 20:58           ` Alan Cox [this message]
     [not found]         ` <478681FE.BANGALORE.BLR.100.174746A.1.ECB1.1@1:7.BANGALORE.BLR.100.0.1.0.1@16>
2008-01-10 15:31           ` Nikanth Karthikesan
2008-01-10 15:50             ` Matthew Wilcox
     [not found]       ` <47854BF3.BANGALORE.BLR.100.174746A.1.EB89.1@1:7.BANGALORE.BLR.100.0.1.0.1@16>
2008-01-10  5:29         ` Nikanth Karthikesan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080110205826.7c41b247@lxorguk.ukuu.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=grant@torque.net \
    --cc=jikos@jikos.cz \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=knikanth@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew@wil.cx \
    --cc=tim@cyberelk.net \
    --subject='Re: [PATCH] Change paride driver to use unlocked_ioctl instead of ioctl' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).