LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Balaji Rao <balajirrao@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: amit.shah@qumranet.com, balbir@in.ibm.com,
	dhaval@linux.vnet.ibm.com, vatsa@linux.vnet.ibm.com,
	venkatesh.pallipadi@intel.com, clemens@ladisch.de,
	tglx@linutronix.de, mingo@elte.hu, hpa@zytor.com
Subject: [PATCH] Assign IRQs to HPET Timers
Date: Sat, 12 Jan 2008 00:36:11 +0530	[thread overview]
Message-ID: <200801120036.11982.balajirrao@gmail.com> (raw)

Assign an IRQ to HPET Timer devices when interrupt enable is requested.
This now makes the HPET userspace API work.

drivers/char/hpet.c  |   31 +++++++++++++++++++++++++++++--
include/linux/hpet.h |    2 +-
2 files changed, 30 insertions(+), 3 deletions(-)

Signed-off-by: Balaji Rao R <balajirrao@gmail.com>

diff --git a/drivers/char/hpet.c b/drivers/char/hpet.c
index 4c16778..92bd889 100644
--- a/drivers/char/hpet.c
+++ b/drivers/char/hpet.c
@@ -390,7 +390,8 @@ static int hpet_ioctl_ieon(struct hpet_dev *devp)
 	struct hpets *hpetp;
 	int irq;
 	unsigned long g, v, t, m;
-	unsigned long flags, isr;
+	unsigned long flags, isr, irq_bitmap;
+	u64 hpet_config;
 
 	timer = devp->hd_timer;
 	hpet = devp->hd_hpet;
@@ -412,7 +413,29 @@ static int hpet_ioctl_ieon(struct hpet_dev *devp)
 		devp->hd_flags |= HPET_SHARED_IRQ;
 	spin_unlock_irq(&hpet_lock);
 
-	irq = devp->hd_hdwirq;
+	/* Assign an IRQ to the timer */
+	hpet_config = readq(&timer->hpet_config);
+	irq_bitmap =
+		(hpet_config & Tn_INT_ROUTE_CAP_MASK) >> Tn_INT_ROUTE_CAP_SHIFT;
+	if (!irq_bitmap)
+		irq = 0;	/* No IRQ Assignable */
+	else {
+		irq = find_first_bit(&irq_bitmap, 32);
+		do {
+			hpet_config |= irq << Tn_INT_ROUTE_CNF_SHIFT;
+			writeq(hpet_config, &timer->hpet_config);
+
+			/* Check whether we wrote a valid IRQ
+			 * number by reading back the field
+			 */
+			hpet_config = readq(&timer->hpet_config);
+			if (irq == (hpet_config & Tn_INT_ROUTE_CNF_MASK)
+					>> Tn_INT_ROUTE_CNF_SHIFT) {
+				devp->hd_hdwirq = irq;
+				break;	/* Success */
+			}
+		} while ((irq = (find_next_bit(&irq_bitmap, 32, irq))));
+	}
 
 	if (irq) {
 		unsigned long irq_flags;
@@ -509,6 +532,10 @@ hpet_ioctl_common(struct hpet_dev *devp, int cmd, unsigned long arg, int kernel)
 			break;
 		v = readq(&timer->hpet_config);
 		v &= ~Tn_INT_ENB_CNF_MASK;
+
+		/* Zero out the IRQ field*/
+		v &= ~Tn_INT_ROUTE_CNF_MASK;
+
 		writeq(v, &timer->hpet_config);
 		if (devp->hd_irq) {
 			free_irq(devp->hd_irq, devp);
diff --git a/include/linux/hpet.h b/include/linux/hpet.h
index 707f7cb..e3c0b2a 100644
--- a/include/linux/hpet.h
+++ b/include/linux/hpet.h
@@ -64,7 +64,7 @@ struct hpet {
  */
 
 #define	Tn_INT_ROUTE_CAP_MASK		(0xffffffff00000000ULL)
-#define	Tn_INI_ROUTE_CAP_SHIFT		(32UL)
+#define	Tn_INT_ROUTE_CAP_SHIFT		(32UL)
 #define	Tn_FSB_INT_DELCAP_MASK		(0x8000UL)
 #define	Tn_FSB_INT_DELCAP_SHIFT		(15)
 #define	Tn_FSB_EN_CNF_MASK		(0x4000UL)

             reply	other threads:[~2008-01-11 18:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-11 19:06 Balaji Rao [this message]
2008-01-12 12:03 ` Balbir Singh
2008-01-12 20:15   ` [PATCH] [RESEND] " Balaji Rao
2008-01-14 15:53     ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200801120036.11982.balajirrao@gmail.com \
    --to=balajirrao@gmail.com \
    --cc=amit.shah@qumranet.com \
    --cc=balbir@in.ibm.com \
    --cc=clemens@ladisch.de \
    --cc=dhaval@linux.vnet.ibm.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=vatsa@linux.vnet.ibm.com \
    --cc=venkatesh.pallipadi@intel.com \
    --subject='Re: [PATCH] Assign IRQs to HPET Timers' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).