LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jens Axboe <jens.axboe@oracle.com>
To: Adrian McMenamin <adrian@newgolddream.dyndns.info>
Cc: Paul Mundt <lethal@linux-sh.org>,
	linux-sh <linux-sh@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] SH/Dreamcast - add support for GD-Rom CDROM drive on  SEGA Dreamcast
Date: Sat, 12 Jan 2008 12:57:43 +0100	[thread overview]
Message-ID: <20080112115740.GH6258@kernel.dk> (raw)
In-Reply-To: <1200088609.6213.3.camel@localhost.localdomain>

On Fri, Jan 11 2008, Adrian McMenamin wrote:
> 
> On Thu, 2008-01-10 at 23:25 +0000, Adrian McMenamin wrote:
> > From: Adrian McMenamin <adrian@mcmen.demon.co.uk>
> > 
> > This patch adds support for the GD-Rom drive, SEGA's proprietary implementation of an IDE CD Rom for the SEGA Dreamcast. This driver implements Sega's Packet Interface (SPI) - at least partially. It will also read disks in SEGA's propreitary GD format.
> > 
> > Unlike previous drivers (which were never in mainline) this uses DMA and not PIO to read disks. It is a new driver, not a refactoring of old drivers. 
> > 
> > Signed-off by: Adrian McMenamin <adrian@mcmen.demon.co.uk>
> > 
> > (Jens - this awaits your ack before going in Paul's queue for the 2.6.25 window)
> > 
> > --------
> > 
> > 
> 
> Unfortunately, there was one small mistake (a repeated assignment), in
> the patch posted yesterday. Here is a corrected version.
> 
> Signed-off by: Adrian McMenamin <adrian@mcmen.demon.co.uk>

The io handling looks ok to me now.

Acked-by: Jens Axboe <jens.axboe@oracle.com>

-- 
Jens Axboe


  reply	other threads:[~2008-01-12 11:57 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-10 23:25 Adrian McMenamin
2008-01-11 21:56 ` Adrian McMenamin
2008-01-12 11:57   ` Jens Axboe [this message]
2008-01-12 13:36   ` Andrew Morton
2008-01-12 14:14     ` Adrian McMenamin
2008-01-12 19:15       ` Andrew Morton
2008-01-13 18:24         ` Adrian McMenamin
2008-01-14 23:00     ` Adrian McMenamin
2008-01-14 23:17       ` Adrian McMenamin
2008-01-15  0:29         ` Paul Mundt
2008-01-15 20:41           ` Adrian McMenamin
2008-01-16  1:57             ` Paul Mundt
2008-01-16 23:57         ` Adrian McMenamin
2008-01-17  1:27           ` Paul Mundt
2008-01-17 22:30             ` Adrian McMenamin
2008-01-18  0:56               ` Paul Mundt
2008-01-28  5:33                 ` Andrew Morton
2008-01-28  5:53                   ` Paul Mundt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080112115740.GH6258@kernel.dk \
    --to=jens.axboe@oracle.com \
    --cc=adrian@newgolddream.dyndns.info \
    --cc=lethal@linux-sh.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --subject='Re: [PATCH] SH/Dreamcast - add support for GD-Rom CDROM drive on  SEGA Dreamcast' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).