LKML Archive on
help / color / mirror / Atom feed
* Fwd: Issue with arm-devel tree
@ 2008-01-12 14:54 Russell King
  2008-01-14 13:09 ` Andre Haupt
  0 siblings, 1 reply; 2+ messages in thread
From: Russell King @ 2008-01-12 14:54 UTC (permalink / raw)
  To: Lucas Woods, Andre Haupt, Michael-Luke Jones
  Cc: Andrew Morton, Linux Kernel List

It might be a good idea if there was some co-ordination with people
involved in the duplicate include removal work...

    [ARM] remove duplicate includes
    Signed-off-by: Lucas Woods <>
    Acked-by: Lennert Buytenhek <>
    Signed-off-by: Andrew Morton <>
    Signed-off-by: Russell King <>

@@ -20,7 +20,6 @@
 #include <linux/module.h>
 #include <linux/irq.h>
 #include <linux/interrupt.h>
-#include <linux/reboot.h>
 #include <asm/mach-types.h>

    [ARM] ixp4xx: remove double include
     Remove double include.
    Signed-off-by: Andre Haupt <>
    Signed-off-by: Alessandro Zummo <>
    Signed-off-by: Andrew Morton <>
    Signed-off-by: Russell King <>

@@ -18,7 +18,6 @@
 #include <linux/module.h>
-#include <linux/reboot.h>
 #include <linux/irq.h>
 #include <linux/interrupt.h>
 #include <linux/reboot.h>

I've dropped the "ixp4xx: remove double include" commit and fixed the
resulting breakage of "remove duplicate includes" change to resolve this

----- Forwarded message from Michael-Luke Jones <> -----

From: Michael-Luke Jones <>
Subject: Issue with arm-devel tree
Date: Sat, 12 Jan 2008 14:23:44 +0000

contains two patches:

"Re: [ARM] remove duplicate includes" from Lucas Woods  
"Re: [ARM] ixp4xx: remove double include" from Andre Haupt  

which between the two of them manage to delete *both* instances of  
#include <linux/reboot.h> in nslu2-power.c

Given that nslu2-power.c calls machine_power_off() and ctrl_alt_del()  
this probably isn't a good thing.

Michael-Luke Jones

----- End forwarded message -----

Russell King

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-01-14 13:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-01-12 14:54 Fwd: Issue with arm-devel tree Russell King
2008-01-14 13:09 ` Andre Haupt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).