LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ondrej Zary <linux@rainbow-software.org>
To: Pierre Ossman <drzeus@drzeus.cx>
Cc: Rene Herman <rene.herman@keyaccess.nl>,
Pavel Machek <pavel@suse.cz>, "Rafael J. Wysocki" <rjw@sisk.pl>,
Jaroslav Kysela <perex@perex.cz>,
ALSA development <alsa-devel@alsa-project.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Bjorn Helgaas <bjorn.helgaas@hp.com>,
Andrew Morton <akpm@osdl.org>, Takashi Iwai <tiwai@suse.de>,
linux-pm@lists.linux-foundation.org
Subject: Re: [alsa-devel] PNP_DRIVER_RES_DISABLE breaks swsusp at least with snd_cs4236
Date: Sat, 12 Jan 2008 17:46:53 +0100 [thread overview]
Message-ID: <200801121746.57177.linux@rainbow-software.org> (raw)
In-Reply-To: <20080112162150.1ec9cad0@poseidon.drzeus.cx>
On Saturday 12 January 2008 16:21:50 Pierre Ossman wrote:
> On Sat, 12 Jan 2008 14:39:47 +0100
>
> Rene Herman <rene.herman@keyaccess.nl> wrote:
> > On 12-01-08 12:12, Pierre Ossman wrote:
> > > I'm a bit confused here. Bjorn Helgaas wanted to remove the
> > > pnp_start/stop_dev() calls completely, and you want them called all the
> > > time. :)
> >
> > Wanted where? Haven't seen a coment from Bjorn? But -- while removing
> > them both looks (as) sensible from a mirror-image viewpoint, this
> > wouldn't fix the problem.
>
> Ah, sorry. It was a different thread. Look for a mail with the subject
> "PNP: do not stop/start devices in suspend/resume path" in the LKML och
> linux-pm archives.
>
> > But we certainly need the pnp_start_dev() in the current flow of things.
> > It not being called is the problem this fixes...
>
> I think the previous suggestion was that the drivers should call this, not
> the core, so that it behaved more like other parts of the kernel (e.g.
> PCI).
I don't think that drivers should call pnp_start_dev() on resume. All drivers
would need to call it as all PnP cards are disabled after boot. No driver
does that currently.
3c509 driver doesn't seem to register as pnp_card_driver so that's probably
why it's not enable after resume. I guess that more ISA PnP drivers have this
problem. I have some other PnP network and sound cards so I'll test them.
--
Ondrej Zary
next prev parent reply other threads:[~2008-01-12 16:47 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-09 22:43 PNP_DRIVER_RES_DISABLE breaks swsusp at least with snd_cs4236 Ondrej Zary
2008-01-10 1:53 ` [alsa-devel] " Rene Herman
2008-01-10 7:58 ` Jaroslav Kysela
2008-01-11 1:19 ` Rene Herman
2008-01-11 7:01 ` Pierre Ossman
2008-01-11 14:21 ` Rene Herman
2008-01-11 18:40 ` Ondrej Zary
2008-01-12 1:23 ` Rene Herman
2008-01-12 11:12 ` Pierre Ossman
2008-01-12 13:39 ` Rene Herman
2008-01-12 15:21 ` Pierre Ossman
2008-01-12 16:46 ` Ondrej Zary [this message]
2008-01-12 17:00 ` Rene Herman
2008-01-12 19:08 ` Rafael J. Wysocki
2008-01-12 20:08 ` -mm: pnp-do-not-stop-start-devices-in-suspend-resume-path.patch breaks resuming isapnp cards Rene Herman
2008-01-13 5:50 ` Bjorn Helgaas
2008-01-13 6:13 ` Rene Herman
2008-01-14 22:26 ` Bjorn Helgaas
2008-01-14 23:46 ` Rene Herman
2008-01-15 7:51 ` Jaroslav Kysela
2008-01-16 17:46 ` Bjorn Helgaas
2008-01-16 18:03 ` Ondrej Zary
2008-01-16 18:16 ` Rene Herman
2008-01-12 19:01 ` [alsa-devel] PNP_DRIVER_RES_DISABLE breaks swsusp at least with snd_cs4236 Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801121746.57177.linux@rainbow-software.org \
--to=linux@rainbow-software.org \
--cc=akpm@osdl.org \
--cc=alsa-devel@alsa-project.org \
--cc=bjorn.helgaas@hp.com \
--cc=drzeus@drzeus.cx \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=pavel@suse.cz \
--cc=perex@perex.cz \
--cc=rene.herman@keyaccess.nl \
--cc=rjw@sisk.pl \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).