LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Benjamin LaHaise <bcrl@kvack.org> To: akpm@osdl.org Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] serial: remove "too much work for irq" printk Date: Sat, 12 Jan 2008 15:15:43 -0500 [thread overview] Message-ID: <20080112201543.GB12775@kvack.org> (raw) When using kvm with a serial console, the serial driver will print out "too much work for irq4" on any heavy activity (ie vi on a file repainting the terminal). This message is entirely spurious, as output continues to work fine. Remove the message as it corrupts screen output and is far too easy to trigger. -ben Signed-off-by: Benjamin LaHaise <bcrl@kvack.org> diff --git a/drivers/serial/8250.c b/drivers/serial/8250.c index f94109c..030b8b5 100644 --- a/drivers/serial/8250.c +++ b/drivers/serial/8250.c @@ -1493,12 +1493,8 @@ static irqreturn_t serial8250_interrupt(int irq, void *dev_id) l = l->next; - if (l == i->head && pass_counter++ > PASS_LIMIT) { - /* If we hit this, we're dead. */ - printk(KERN_ERR "serial8250: too much work for " - "irq%d\n", irq); + if (l == i->head && pass_counter++ > PASS_LIMIT) break; - } } while (l != end); spin_unlock(&i->lock);
next reply other threads:[~2008-01-12 20:16 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2008-01-12 20:15 Benjamin LaHaise [this message] 2008-01-12 20:21 ` [PATCH] serial: remove "too much work for irq" printk Christoph Hellwig 2008-01-12 21:24 ` Alan Cox 2008-01-12 21:39 ` H. Peter Anvin 2008-01-12 21:42 ` Alan Cox 2008-01-12 21:58 ` H. Peter Anvin 2008-01-13 22:03 ` Pavel Machek
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20080112201543.GB12775@kvack.org \ --to=bcrl@kvack.org \ --cc=akpm@osdl.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-serial@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).