LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Bjorn Helgaas <email@example.com> To: Rene Herman <firstname.lastname@example.org> Cc: Andrew Morton <email@example.com>, "Rafael J. Wysocki" <firstname.lastname@example.org>, Pierre Ossman <email@example.com>, Pavel Machek <firstname.lastname@example.org>, Ondrej Zary <email@example.com>, Jaroslav Kysela <firstname.lastname@example.org>, ALSA development <email@example.com>, Linux Kernel <firstname.lastname@example.org>, Takashi Iwai <email@example.com>, firstname.lastname@example.org Subject: Re: -mm: pnp-do-not-stop-start-devices-in-suspend-resume-path.patch breaks resuming isapnp cards Date: Sat, 12 Jan 2008 22:50:42 -0700 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <47891E21.firstname.lastname@example.org> On Saturday 12 January 2008 1:08:01 pm Rene Herman wrote: > pnp-do-not-stop-start-devices-in-suspend-resume-path.patch in current -mm > breaks resuming isapnp cards from hibernation. They need the pnp_start_dev > to enable the device again after hibernation. > > They don't really need the pnp_stop_dev() which the above mentioned patch > also removes but with the pnp_start_dev() restored it seems pnp_stop_dev() > should also stay. Bjorn Helgaas should decide -- currently the patch as > you have it breaks drivers though. Could you drop it? Yes, please drop pnp-do-not-stop-start-devices-in-suspend-resume-path.patch for now. When the PNP core requested resources for active devices, the pnp_stop_dev() in the suspend path released the PNP core resources, leaving the underlying driver resources orphaned. But the patch that made the PNP core request those resource is also gone, so we can leave the start/stop alone. > On 12-01-08 20:08, Rafael J. Wysocki wrote: > > On Saturday, 12 of January 2008, Rene Herman wrote: > >> It seems all PnP drivers would need to stick a pnp_start_dev in their > >> resume method > > > > Yes. > > > >> then which means it really belongs in core. > > > > Yes, if practical. > > > >> One important point where PnP and PCI differ is that PnP allows to > >> change the resources on a protocol level and I don't see how it could > >> ever not be necessary to restore the state a user may have set if power > >> has been removed. Hibernate is just that, isn't it? That's a good point, thanks for pointing that out. Bjorn
next prev parent reply other threads:[~2008-01-13 5:53 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2008-01-09 22:43 PNP_DRIVER_RES_DISABLE breaks swsusp at least with snd_cs4236 Ondrej Zary 2008-01-10 1:53 ` [alsa-devel] " Rene Herman 2008-01-10 7:58 ` Jaroslav Kysela 2008-01-11 1:19 ` Rene Herman 2008-01-11 7:01 ` Pierre Ossman 2008-01-11 14:21 ` Rene Herman 2008-01-11 18:40 ` Ondrej Zary 2008-01-12 1:23 ` Rene Herman 2008-01-12 11:12 ` Pierre Ossman 2008-01-12 13:39 ` Rene Herman 2008-01-12 15:21 ` Pierre Ossman 2008-01-12 16:46 ` Ondrej Zary 2008-01-12 17:00 ` Rene Herman 2008-01-12 19:08 ` Rafael J. Wysocki 2008-01-12 20:08 ` -mm: pnp-do-not-stop-start-devices-in-suspend-resume-path.patch breaks resuming isapnp cards Rene Herman 2008-01-13 5:50 ` Bjorn Helgaas [this message] 2008-01-13 6:13 ` Rene Herman 2008-01-14 22:26 ` Bjorn Helgaas 2008-01-14 23:46 ` Rene Herman 2008-01-15 7:51 ` Jaroslav Kysela 2008-01-16 17:46 ` Bjorn Helgaas 2008-01-16 18:03 ` Ondrej Zary 2008-01-16 18:16 ` Rene Herman 2008-01-12 19:01 ` [alsa-devel] PNP_DRIVER_RES_DISABLE breaks swsusp at least with snd_cs4236 Rafael J. Wysocki
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).